8000 feat: implement --staged flag by todor-a · Pull Request #868 · dprint/dprint · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement --staged flag #868

Merged
merged 9 commits into from
Jun 30, 2024
Merged

feat: implement --staged flag #868

merged 9 commits into from
Jun 30, 2024

Conversation

todor-a
Copy link
Contributor
@todor-a todor-a commented Jun 28, 2024 •
edited
Loading

This is an attempt to implement/port biome's --staged flag when formatting/checking.

The implementation just takes over the arg_includes field of the glob pattern field which I am not too sure about. I was wondering if it should be a dedicated property but at the end went with just reusing arg_includes. Which poses the question, should I add validation that --staged and specific files param can't be used together?

let me know what do you think when you get a chance @dsherret

@CLAassistant
Copy link
CLAassistant commented Jun 28, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@todor-a todor-a marked this pull request as draft June 28, 2024 20:13
@todor-a todor-a marked this pull request as ready for review June 28, 2024 20:14
@todor-a todor-a marked this pull request as draft June 29, 2024 13:29
@todor-a todor-a marked this pull request as ready for review June 30, 2024 11:26
@dprint dprint deleted a comment from CLAassistant Jun 30, 2024
dsherret
dsherret reviewed Jun 30, 2024
View reviewed changes
Copy link
Member
@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should surface the error on failure, but looks great otherwise.

dsherret
dsherret approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member
@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm going to do a release this evening so I pushed some changes to get this merged.

@dsherret dsherret merged commit 8e8266b into dprint:main Jun 30, 2024
10 checks passed
This was referenced Jul 31, 2024
Merged
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@todor-a @CLAassistant @dsherret
0