8000 Add support for specifying Microsoft.NET.Sdk.Web as the sdk by seesharper · Pull Request #694 · dotnet-script/dotnet-script · GitHub
[go: up one dir, main page]
Skip to content

Add support for specifying Microsoft.NET.Sdk.Web as the sdk #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Nov 26, 2022
Merged

Add support for specifying Microsoft.NET.Sdk.Web as the sdk #694

merged 20 commits into from
Nov 26, 2022

Conversation

seesharper
Copy link
Collaborator
@seesharper seesharper commented Nov 24, 2022 •
edited
Loading

This PR adds support for specifying an SDK using the #r directive.
The feature is restricted to Microsoft.NET.Sdk.Web at the moment.

Example

#r "sdk:Microsoft.NET.Sdk.Web"

using Microsoft.AspNetCore.Builder;

var a = WebApplication.Create();
a.MapGet("/", () => "Hello world");
a.Run();

This PR also includes a number of updates to NuGet packages referenced by dotnet-script. This should minimize the need for --isolated-load-context. Also removed a few dependencies that are no longer needed. Some of them was just referenced to make things work back when we were at netcoreapp2.1.

Other news. Removed support for Chocolatey 😃

@seesharper seesharper changed the title W.I.P (DO NOT MERGE) Specify sdk Add support for specifying Microsoft.NET.Sdk.Web as the sdk Nov 25, 2022
@seesharper seesharper requested a review from filipw November 25, 2022 13:13
filipw
filipw reviewed Nov 25, 2022
View reviewed changes
filipw
filipw reviewed Nov 25, 2022
View reviewed changes
filipw
filipw approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member
@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! I just left a few small comments

@seesharper seesharper mentioned this pull request Nov 25, 2022
Closed
@filipw filipw merged commit 6f2fe27 into master Nov 26, 2022
@filipw
Copy link
Member
filipw commented Nov 26, 2022

Thanks!

@filipw filipw deleted the specify-sdk branch November 26, 2022 11:26
@ihqtim
Copy link
ihqtim commented Nov 28, 2022

Great, much appreciated!

@filipw filipw mentioned this pull request Jun 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipw filipw filipw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seesharper @filipw @ihqtim @God-damnit-all
0