8000 removed unnecessary CS8073 warnings by filipw · Pull Request #690 · dotnet-script/dotnet-script · GitHub
[go: up one dir, main page]
Skip to content

removed unnecessary CS8073 warnings #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2022
Merged

removed unnecessary CS8073 warnings #690

merged 1 commit into from
Oct 24, 2022

Conversation

filipw
Copy link
Member
@filipw filipw commented Oct 24, 2022

SyntaxTrivia and SyntaxToken are non nullable

/Users/filipw/dev/dotnet-script/src/Dotnet.Script.Core/Internal/PreprocessorLineRewriter.cs(28,17): warning CS8073: The result of the expression is always 'true' since a value of type 'SyntaxTrivia' is never equal to 'null' of type 'SyntaxTrivia?' [/Users/filipw/dev/dotnet-script/src/Dotnet.Script.Core/Dotnet.Script.Core.csproj::TargetFramework=net6.0]
/Users/filipw/dev/dotnet-script/src/Dotnet.Script.Core/Internal/PreprocessorLineRewriter.cs(31,21): warning CS8073: The result of the expression is always 'true' since a value of type 'SyntaxToken' is never equal to 'null' of type 'SyntaxToken?' [/Users/filipw/dev/dotnet-script/src/Dotnet.Script.Core/Dotnet.Script.Core.csproj::TargetFramework=net6.0]

@filipw filipw requested a review from seesharper October 24, 2022 09:42
seesharper
seesharper reviewed Oct 24, 2022
View reviewed changes
Copy link
Collaborator
@seesharper seesharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍😃

@seesharper seesharper merged commit 124737c into master Oct 24, 2022
@filipw filipw deleted the bugfix/CS8073 branch October 28, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seesharper seesharper seesharper left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipw @seesharper
0