8000 Don't write diagnostics to stdOut by seesharper · Pull Request #686 · dotnet-script/dotnet-script · GitHub
[go: up one dir, main page]
Skip to content

Don't write diagnostics to stdOut #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 26, 2022
Merged

Don't write diagnostics to stdOut #686

merged 3 commits into from
Sep 26, 2022

Conversation

seesharper
Copy link
Collaborator

This PR fixes #657 by writing warnings from the compiler (Diagnostics) to stdErr instead of stdOut as we used to.
As mentioned in the issue this causes "pollution" of the stdOut stream and could cause issues when for instance piping the output from dotnet.script to another command.

Tried to make this with as little changes to the tests as possible. We now return a ProcessResult with a deconstruct that matches the tuple used in many tests.

@seesharper seesharper requested a review from filipw September 25, 2022 21:17
filipw
filipw approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member
@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@filipw filipw merged commit fc932e5 into master Sep 26, 2022
@filipw filipw deleted the issue657 branch September 26, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipw filipw filipw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop compiler warnings being written to stdout
2 participants
@seesharper @filipw
0