8000 updated to Roslyn 4 by filipw · Pull Request #646 · dotnet-script/dotnet-script · GitHub
[go: up one dir, main page]
Skip to content
/ dotnet-script Public

updated to Roslyn 4 #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
8000 Merged
merged 2 commits into from
Nov 9, 2021
Merged

updated to Roslyn 4 #646

merged 2 commits into from
Nov 9, 2021

Conversation

filipw
Copy link
Member
@filipw filipw commented Nov 9, 2021

No description provided.

@filipw filipw requested a review from seesharper November 9, 2021 09:51
seesharper
seesharper approved these changes Nov 9, 2021
View reviewed changes
Copy link
Collaborator
@seesharper seesharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎂

seesharper
seesharper approved these changes Nov 9, 2021
View reviewed changes
Copy link
Collaborator
@seesharper seesharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goods. Just need to update this :)

https://github.com/filipw/dotnet-script/blob/e496584150a3246063c69ddad664e2db70704bd0/src/Dotnet.Script.Core/ScriptPublisher.cs#L14

@filipw
Copy link
Member Author
filipw commented Nov 9, 2021

oops

@filipw filipw merged commit e8ef9b6 into master Nov 9, 2021
@filipw filipw deleted the feature/roslyn-4 branch November 9, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seesharper seesharper seesharper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipw @seesharper
0