10000 Support for .Net 5 by seesharper · Pull Request #589 · dotnet-script/dotnet-script · GitHub
[go: up one dir, main page]
Skip to content

Support for .Net 5 #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 10, 2020
Merged

Support for .Net 5 #589

merged 12 commits into from
Nov 10, 2020

Conversation

seesharper
Copy link
Collaborator

This PR adds support for .Net 5.

The most significant changes are related to publishing scripts.

we use to do

var path = Path.GetDirectoryName(Assembly.GetEntryAssembly().Location);

Trying to do this in a single file app now yields

warning IL3000: 'System.Reflection.Assembly.Location' always returns an empty string for assemblies embedded in a single-file app.

So instead we load the scriptAssembly.dll by its name instead. This also resulted in a small change where we give the emitted assembly a name so that it can be loaded by name.

@seesharper seesharper requested a review from filipw November 10, 2020 12:13
@filipw filipw merged commit 48ec1e5 into master Nov 10, 2020
@filipw
Copy link
Member
filipw commented Nov 10, 2020

🥇 🔥 🎆

@filipw filipw deleted the netcoreapp5.0 branch November 10, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipw filipw filipw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seesharper @filipw
0