8000 Remove double lookups on SizeLimitedCache<K, V>, improve performance by h3xds1nz · Pull Request #9949 · dotnet/wpf · GitHub
[go: up one dir, main page]
Skip to content

Remove double lookups on SizeLimitedCache<K, V>, improve performance #9949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 6, 2025
Merged

Remove double lookups on SizeLimitedCache<K, V>, improve performance #9949

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e47d652
Fix double lookup on Get
h3xds1nz Oct 13, 2024
3ab3000
Mark fields that could be readonly, functions that could be static
h3xds1nz Oct 13, 2024
6bb5f47
Fix double lookup on Add
h3xds1nz Oct 13, 2024
6038a66
Naming cleanup, seal the class
h3xds1nz Oct 13, 2024
e07abea
Change the fields order
h3xds1nz Oct 13, 2024
257c32a
Seal Node as well, use auto properties
h3xds1nz Oct 13, 2024
0bcfdea
Fix additional lookup on Remove
h3xds1nz Oct 13, 2024
ebcfa79
Whitespaces
h3xds1nz Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix double lookup on Add
  • Loading branch information
@h3xds1nz
h3xds1nz committed Feb 28, 2025
commit 6bb5f47b6266eea8ec1db417db182e56058144ad
33 changes: 8 additions & 25 deletions src/Microsoft.DotNet.Wpf/src/Shared/MS/Internal/SizeLimitedCache.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,20 +85,13 @@ public int MaximumItems
/// </param>
public void Add(K key, V resource, bool isPermanent)
{

if ( (object)key == null)
{
throw new ArgumentNullException(nameof(key));
}
if ( (object)resource == null)
{
throw new ArgumentNullException(nameof(resource));
}
ArgumentNullException.ThrowIfNull(key, nameof(key));
ArgumentNullException.ThrowIfNull(resource, nameof(resource));

// note: [] throws, thus we should check if its in the dictionary first.
if (!_nodeLookup.ContainsKey(key))
if (!_nodeLookup.TryGetValue(key, out Node node))
{
Node node = new Node(key, resource, isPermanent);
node = new Node(key, resource, isPermanent);
if (!isPermanent)
{
if (IsFull())
Expand All @@ -111,11 +104,11 @@ public void Add(K key, V resource, bool isPermanent)
{
_permanentCount++;
}

_nodeLookup[key] = node;
}
else
{
Node node = _nodeLookup[key];
if (!node.IsPermanent)
{
RemoveFromList(node);
Expand Down Expand Up @@ -151,27 +144,17 @@ public void Add(K key, V resource, bool isPermanent)
/// </param>
public void Remove(K key)
{
if ( (object)key == null)
{
throw new ArgumentNullException(nameof(key));
}
ArgumentNullException.ThrowIfNull(key, nameof(key));

// note: [] throws, thus we should check if its in the dictionary first.
if (!_nodeLookup.ContainsKey(key))
{
if (!_nodeLookup.TryGetValue(key, out Node node))
return;
}
Node node = _nodeLookup[key];

_nodeLookup.Remove(key);

if (!node.IsPermanent)
{
RemoveFromList(node);
}
else
{
_permanentCount--;
}
}

/// <summary>
Expand Down
0