8000 Remove OleCmdHelper/ISecureCommand dead code (CAS/XBAP leftovers) by h3xds1nz · Pull Request #9943 · dotnet/wpf · GitHub
[go: up one dir, main page]
Skip to content

Remove OleCmdHelper/ISecureCommand dead code (CAS/XBAP leftovers) #9943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 31, 2024
Merged

Remove OleCmdHelper/ISecureCommand dead code (CAS/XBAP leftovers) #9943

merged 3 commits into from
Dec 31, 2024

Conversation

h3xds1nz
Copy link
Member
@h3xds1nz h3xds1nz commented Oct 11, 2024 •
edited by dotnet-policy-service bot
Loading

Description

Continues #9855 and #9865, removing even more XBAP related dead code (and some CAS related code).

  • OleCmdHelper is uncalled, CommandWithArgument was only used in OleCmdHelper.
  • ISecureCommand was also referenced via OleCmdHelper though it has been gutted out during CAS removal.
  • SecureUICommand was created using CommandLibraryHelper on NetFX, removed during CAS removal too.

Customer Impact

Smaller assembly size, improved code base quality for developers.

Regression

No.

Testing

Local build.

Risk

I believe there is none, those classes are uncalled and interface unused since CAS removal.

Microsoft Reviewers: Open in CodeFlow

< 8000 /svg>

@h3xds1nz h3xds1nz requested review from a team as code owners October 11, 2024 17:37
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Oct 11, 2024
@h3xds1nz h3xds1nz mentioned this pull request Nov 11, 2024
Merged
harshit7962
harshit7962 previously approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member
@harshit7962 harshit7962 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@h3xds1nz, the PR can be merged post resolution of conflicts.

8000

@h3xds1nz h3xds1nz force-pushed the remove-more-browser-stuff branch from cd58666 to bfa8712 Compare December 31, 2024 12:11
@h3xds1nz
Copy link
Member Author

@harshit7962 Resolved.

8000
harshit7962
harshit7962 approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member
@harshit7962 harshit7962 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproving after resolution of merge conflicts.

@harshit7962 harshit7962 merged commit 7bccb25 into dotnet:main Dec 31, 2024
8 checks passed
@harshit7962
Copy link
Member

@h3xds1nz Thank you for your continued contributions.

@h3xds1nz
Copy link
Member Author

@harshit7962 Thanks for iteratively working through them :)

@harshit7962 harshit7962 self-assigned this Jan 3, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@harshit7962 harshit7962 harshit7962 approved these changes

@dipeshmsft dipeshmsft Awaiting requested review from dipeshmsft

@singhashish-wpf singhashish-wpf Awaiting requested review from singhashish-wpf

Assignees

@harshit7962 harshit7962

@h3xds1nz h3xds1nz

Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h3xds1nz @harshit7962
0