8000 Remove SecurityCriticalData/Class by JeremyKuhne · Pull Request #9882 · dotnet/wpf · GitHub
[go: up one dir, main page]
Skip to content

Remove SecurityCriticalData/Class #9882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2024
Merged

Remove SecurityCriticalData/Class #9882

merged 2 commits into from
Oct 7, 2024

Conversation

JeremyKuhne
Copy link
Member
@JeremyKuhne JeremyKuhne commented Oct 3, 2024 •
edited by dotnet-policy-service bot
Loading

These are CAS holdovers from .NET Framework that add unnecessary complexity. (They are making it more difficult for me to do interop work.)

Uses more modern / safer syntax where I've modified code. I've also removed a few asserts where they then fall over on the next line anyway.

Similar to and should follow #7161 and #6561

Microsoft Reviewers: Open in CodeFlow

@JeremyKuhne JeremyKuhne requested review from a team as code owners October 3, 2024 01:47
@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Oct 3, 2024
lonitra
lonitra reviewed Oct 4, 2024
View reviewed changes
Copy link
Member
@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly minor style comments. Otherwise LGTM 👍

@JeremyKuhne
Copy link
Member Author

@dipeshmsft: @lonitra's suggestions are nits that I'll take care of in the other PR's I'm working on if we don't find anything logically wrong that requires an update here.

@JeremyKuhne
Remove SecurityCriticalData/Class
50810e5 
These are CAS holdovers from .NET Framework that add unnecessary complexity.

Uses more modern / safer syntax where I've modified code. I've also removed a few asserts where they then fall over on the next line anyway.

Similar to and should follow dotnet#7161 and dotnet#6561
@JeremyKuhne
Copy link
Member Author

Rebased and addressed feedback

@dipeshmsft
Copy link
Member

@JeremyKuhne , reviewed the PR. All looks good, some style changes needed here and there, but that are probably fine. Going ahead with the merge.

@dipeshmsft dipeshmsft merged commit 278c355 into dotnet:main Oct 7, 2024
8 checks passed
@h3xds1nz h3xds1nz mentioned this pull request Oct 24, 2024
Open
@ThomasGoulet73 ThomasGoulet73 mentioned this pull request Oct 29, 2024
Open
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lonitra lonitra lonitra left review comments

@dipeshmsft dipeshmsft dipeshmsft approved these changes

@singhashish-wpf singhashish-wpf Awaiting requested review from singhashish-wpf

Assignees

@JeremyKuhne JeremyKuhne

Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeremyKuhne @dipeshmsft @lonitra
0