-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove SecurityCriticalData/Class #9882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly minor style comments. Otherwise LGTM 👍
src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/DefaultTextStore.cs
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/MouseDevice.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/MouseDevice.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/MouseDevice.cs
Outdated
Show resolved
Hide resolved
...icrosoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/Stylus/Wisp/PenThreadWorker.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/InterOp/HwndMouseInputProvider.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Documents/FixedSchema.cs
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Documents/TextServicesHost.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/WindowsBase/System/Windows/Threading/Dispatcher.cs
Outdated
Show resolved
Hide resolved
@dipeshmsft: @lonitra's suggestions are nits that I'll take care of in the other PR's I'm working on if we don't find anything logically wrong that requires an update here. |
These are CAS holdovers from .NET Framework that add unnecessary complexity. Uses more modern / safer syntax where I've modified code. I've also removed a few asserts where they then fall over on the next line anyway. Similar to and should follow dotnet#7161 and dotnet#6561
c267c07
to
50810e5
Compare
Rebased and addressed feedback |
@JeremyKuhne , reviewed the PR. All looks good, some style changes needed here and there, but that are probably fine. Going ahead with the merge. |
These are CAS holdovers from .NET Framework that add unnecessary complexity. (They are making it more difficult for me to do interop work.)
Uses more modern / safer syntax where I've modified code. I've also removed a few asserts where they then fall over on the next line anyway.
Similar to and should follow #7161 and #6561
Microsoft Reviewers: Open in CodeFlow