8000 Optimize conversion of Key enum from/to string, reduce allocations by h3xds1nz · Pull Request #9697 · dotnet/wpf · GitHub
[go: up one dir, main page]
Skip to content

Optimize conversion of Key enum from/to string, reduce allocations #9697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 30, 2024
Merged

Optimize conversion of Key enum from/to string, reduce allocations #9697

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a885fbb
Simplify CanConvertFrom
h3xds1nz Aug 31, 2024
7b3a494
Simplify CanConvertTo
h3xds1nz Aug 31, 2024
0790ad2
Speed up and simplify ConvertFrom, add fast-path for F-keys
h3xds1nz Aug 31, 2024
602a17b
Speed up and simplify ConvertTo, add IsDefinedKey helper
h3xds1nz Aug 31, 2024
9a4314d
Add documentation, formatting adjustments only
h3xds1nz Aug 31, 2024
a437634
Use IsDefinedKey in CanConvertTo as well
h3xds1nz Aug 31, 2024
cc4bcbc
Remove redundant usings
h3xds1nz Aug 31, 2024
b4bb170
Fix an unlikely IndexOutOfRangeException we could have introduced
h3xds1nz Aug 31, 2024
92df958
Prevent behaviour change, let it throw an exception
h3xds1nz Sep 1, 2024
189c277
Address PR feedback
h3xds1nz Sep 5, 2024
ae7bac8
Address nits, fix spelling
h3xds1nz Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
0