8000 Replace boxing IList in HighlightChangedEventArgs and seal derived classes by edwardneal · Pull Request #9559 · dotnet/wpf · GitHub
[go: up one dir, main page]
Skip to content

Replace boxing IList in HighlightChangedEventArgs and seal derived classes #9559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2025
Merged

Replace boxing IList in HighlightChangedEventArgs and seal derived classes #9559

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49573cb
Removed use of boxing IList
edwardneal Aug 12, 2024
3bb29ce
Sealed HighlightChangeEventArgs derivatives
edwardneal Aug 12, 2024
8e5f948
Merge main
edwardneal May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Sealed HighlightChangeEventArgs derivatives
  • Loading branch information
@edwardneal
edwardneal committed Aug 12, 2024
commit 3bb29ced6db8e8eca81f931f20227ca60f9e3ade
2 changes: 1 addition & 1 deletion ...f/src/PresentationFramework/MS/Internal/Annotations/Component/AnnotationHighlightLayer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,7 @@ private bool IsFixedContainer
#region Private Types

// Argument for the Changed event, encapsulates a highlight change.
private class AnnotationHighlightChangedEventArgs : HighlightChangedEventArgs
private sealed class AnnotationHighlightChangedEventArgs : HighlightChangedEventArgs
{
// Constructor.
internal AnnotationHighlightChangedEventArgs(ITextPointer start, ITextPointer end)
Expand Down
2 changes: 1 addition & 1 deletion ....Wpf/src/PresentationFramework/System/Windows/Documents/DocumentSequenceHighlightLayer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ internal override Type OwnerType

#region Private Classes
// Argument for the Changed event, encapsulates a highlight change.
private class DocumentSequenceHighlightChangedEventArgs : HighlightChangedEventArgs
private sealed class DocumentSequenceHighlightChangedEventArgs : HighlightChangedEventArgs
{
// Constructor.
internal DocumentSequenceHighlightChangedEventArgs(IList<TextSegment> ranges)
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Documents/Highlights.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ private int LayerCount
#region Private Types

// EventArgs for the Changed event.
private class LayerHighlightChangedEventArgs : HighlightChangedEventArgs
private sealed class LayerHighlightChangedEventArgs : HighlightChangedEventArgs
{
// Constructor.
internal LayerHighlightChangedEventArgs(ReadOnlyCollection<TextSegment> ranges, Type ownerType)
Expand Down
2 changes: 1 addition & 1 deletion ...ft.DotNet.Wpf/src/PresentationFramework/System/Windows/Documents/SpellerHighlightLayer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ private static TextDecorationCollection GetErrorTextDecorations()
#region Private Types

// Argument for the Changed event, encapsulates a highlight change.
private class SpellerHighlightChangedEventArgs : HighlightChangedEventArgs
private sealed class SpellerHighlightChangedEventArgs : HighlightChangedEventArgs
{
// Constructor.
internal SpellerHighlightChangedEventArgs(ITextPointer start, ITextPointer end)
Expand Down
2 changes: 1 addition & 1 deletion ...Net.Wpf/src/PresentationFramework/System/Windows/Documents/TextSelectionHighlightLayer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ private bool IsTextRangeEmpty(ITextRange textRange)
#region Private Types

// Argument for the Changed event, encapsulates a highlight change.
private class TextSelectionHighlightChangedEventArgs : HighlightChangedEventArgs
private sealed class TextSelectionHighlightChangedEventArgs : HighlightChangedEventArgs
{
// Constructor.
internal TextSelectionHighlightChangedEventArgs(ITextPointer invalidRangeLeftStart, ITextPointer invalidRangeLeftEnd,
Expand Down
Loading
0