8000 Implemented Application.ThemeMode and Window.ThemeMode properties by dipeshmsft · Pull Request #9436 · dotnet/wpf · GitHub
[go: up one dir, main page]
Skip to content

Implemented Application.ThemeMode and Window.ThemeMode properties #9436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jul 22, 2024
Merged

Implemented Application.ThemeMode and Window.ThemeMode properties #9436

merged 15 commits into from
Jul 22, 2024

Conversation

dipeshmsft
Copy link
Member
@dipeshmsft dipeshmsft commented Jul 22, 2024 •
edited by dotnet-policy-service bot
Loading

Fixes #

Main PR

Description

Customer Impact

Regression

Testing

Risk

Microsoft Reviewers: Open in CodeFlow

@dipeshmsft dipeshmsft requested review from a team as code owners July 22, 2024 07:54
@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Jul 22, 2024
lindexi
lindexi reviewed Jul 22, 2024
View reviewed changes
h3xds1nz
h3xds1nz suggested changes Jul 22, 2024
View reviewed changes
@dotnet-policy-service dotnet-policy-service bot added the 📭 waiting-author-feedback To request more information from author. label Jul 22, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback To request more information from author. label Jul 22, 2024
pchaurasia14
pchaurasia14 requested changes Jul 22, 2024
View reviewed changes
@dotnet-policy-service dotnet-policy-service bot added the 📭 waiting-author-feedback To request more information from author. label Jul 22, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback To request more information from author. label Jul 22, 2024
@dipeshmsft
Copy link
Member Author

@batzen, @miloush - We are merging this PR for now since it contains the API changes that we want to ship with Preview 7 (and the deadline is today). Please review this PR and I'll address those fixes in the next cycle.

@dipeshmsft dipeshmsft merged commit 6c4dff6 into dotnet:main Jul 22, 2024
8 checks passed
@h3xds1nz h3xds1nz mentioned this pull request Jul 27, 2024
Merged
@dipeshmsft dipeshmsft mentioned this pull request Aug 2, 2024
Merged
@dipeshmsft
Copy link
Member Author

Thanks @ThomasGoulet73 @batzen @miloush @lindexi @h3xds1nz for your reviews on this PR. I have created a PR fixing this comments #9514.

dipeshmsft added a commit that referenced this pull request Aug 8, 2024
@dipeshmsft @pegasus-lynx
Resolving PR #9436 ( Implementing ThemeMode properties ) comments (#9514
5922b87 
)

* Removed windows from FluentEnabledWindows on dispose

* Simplified resync clause and removed redundant steps.

* Made FluentThemeState a record struct

* Added const Fluent theme dictionary strings

* Removed ToString override from FluentThemeState

* Renaming const and static private fields

* Fixing the if clause

* Formatted ThemeManager

---------

Co-authored-by: Dipesh Kumar <dipeshkrj14@gmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@batzen batzen batzen left review comments

@miloush miloush miloush left review comments

@lindexi lindexi lindexi left review comments

@ThomasGoulet73 ThomasGoulet73 ThomasGoulet73 left review comments

@h3xds1nz h3xds1nz h3xds1nz requested changes

@pchaurasia14 pchaurasia14 pchaurasia14 approved these changes

@singhashish-wpf singhashish-wpf Awaiting requested review from singhashish-wpf

Assignees

@dipeshmsft dipeshmsft

Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dipeshmsft @batzen @miloush @lindexi @ThomasGoulet73 @h3xds1nz @pchaurasia14 @harshit7962
0