Fix(Fluent): TextBox invalidation style #10887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #10826 by updating the error template for TextBox controls in the Fluent theme to align with Fluent design guidelines instead of the Aero theme.
- Adds a new ControlTemplate (DefaultTextBoxInvalidationStyle) to Fluent.xaml, Fluent.Light.xaml, Fluent.HC.xaml, Fluent.Dark.xaml, and TextBox.xaml.
- Updates DefaultTextBoxStyle to reference the new error template in each theme file and introduces a shared resource (ErrorTemplateBorderPadding) in Variables.xaml.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Fluent.xaml | Added DefaultTextBoxInvalidationStyle and updated TextBox style to use the new error template |
| Fluent.Light.xaml | Added DefaultTextBoxInvalidationStyle and updated TextBox style similarly |
| Fluent.HC.xaml | Added DefaultTextBoxInvalidationStyle and updated TextBox style similarly |
| Fluent.Dark.xaml | Added DefaultTextBoxInvalidationStyle and updated TextBox style similarly |
| TextBox.xaml | Added DefaultTextBoxInvalidationStyle with a reference to a shared Padding resource |
| Variables.xaml | Introduced ErrorTemplateBorderPadding to support the new error template |
src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Themes/Fluent.xaml
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Themes/Fluent.Light.xaml
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Themes/Fluent.HC.xaml
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Themes/Fluent.Dark.xaml
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10887 +/- ##
===========================================
Coverage 2.98814% 2.98814%
===========================================
Files 3319 3319
Lines 664895 664895
Branches 74675 74675
===========================================
Hits 19868 19868
Misses 644846 644846
Partials 181 181
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dipeshmsft
reviewed
May 30, 2025
src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Resources/Variables.xaml
Outdated
Show resolved
Hide resolved
dipeshmsft
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10826
Description
The invalidation style for the Fluent theme was not altered, resulting in the rendering of styles defined by the Aero theme. These changes add an error template for a textbox to align with Fluent design.
Customer Impact
Better looking UI
Regression
None
Testing
Local build pass
Validated with a sample application
Risk
Low
Microsoft Reviewers: Open in CodeFlow