Fix crashes in TextBox(es) in Fluent theme #10841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
The purpose of this PR is to eliminate crashes in Fluent-themed TextBox, RichTextBox, and PasswordBox controls when using the System theme by replacing StaticResource references with DynamicResource for BorderThickness.
- Updated Resource references in TextBox.xaml
- Updated Resource references in RichTextBox.xaml
- Updated Resource references in PasswordBox.xaml
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| TextBox.xaml | Replaced StaticResource with DynamicResource for BorderThickness in multiple triggers and setters |
| RichTextBox.xaml | Replaced StaticResource with DynamicResource for BorderThickness in control and focused state setters |
| PasswordBox.xaml | Replaced StaticResource with DynamicResource for BorderThickness in focused state setters |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10841 +/- ##
===================================================
- Coverage 13.62876% 13.43457% -0.19419%
===================================================
Files 3316 3316
Lines 664822 664822
Branches 74651 74651
===================================================
- Hits 90607 89316 -1291
- Misses 571519 572908 +1389
+ Partials 2696 2598 -98
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dipeshmsft
approved these changes
May 12, 2025
|
LGTM |
dipeshmsft
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since Preview 4, the creation of TextBox, PasswordBox and RichTextBox was crashing when using
Systemtheme. This was due to the assignment of it'sBorderThicknessasStaticResourceand the resource being declared inVariables.xamlwhich is a sibling ofTextBox.xamland other files inFluent.xamland hence resulting in the crash. The changes here aims to resolve this using theDynamicResource.Customer Impact
Crash free fluent applications when using
Systemtheme.Regression
Yes
Testing
Local Build Pass,
Verified the working using a sample application
Risk
Low
Microsoft Reviewers: Open in CodeFlow