10000 Adding more MessageBox buttons and result values by bstordrup · Pull Request #10720 · dotnet/wpf · GitHub
[go: up one dir, main page]
Skip to content

Adding more MessageBox buttons and result values #10720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 17, 2025
Merged

Adding more MessageBox buttons and result values #10720

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
357f121
Added additional MessageBoxButtons
bstordrup Aug 22, 2024
345985d
Correction to order in MessageBoxButton enum
bstordrup Apr 1, 2025
bb75b6a
Whitespace fixes
bstordrup Apr 7, 2025
70d66f0
More whitespace fixes
bstordrup Apr 7, 2025
4c63ec0
More whitespace fixes
bstordrup Apr 7, 2025
779dbb5
Further whitespace
bstordrup Apr 7, 2025
f86d66c
Whitespace
bstordrup Apr 7, 2025
4880b00
Whitespace
bstordrup Apr 7, 2025
24040f8
Whitespace again
bstordrup Apr 7, 2025
bd92364
Whitespace
bstordrup Apr 7, 2025
0de729e
Whitespace
bstordrup Apr 7, 2025
7582112
Ad 10000 ded tests to test exceptional paths of MessageBox.ShowCore
bstordrup Apr 8, 2025
34cf438
Reorganized tests
bstordrup Apr 8, 2025
e91ad50
Changed the problematic test after advice.
bstordrup Apr 8, 2025
6fa2ac8
Reverted to InlineData
bstordrup Apr 10, 2025
ca0bcd5
Final adjustments
bstordrup Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Correction to order in MessageBoxButton enum
  • Loading branch information
@bstordrup
bstordrup committed Apr 7, 2025
commit 345985d30329156fe2c7ef3371d7f7e2237a560c
4 changes: 2 additions & 2 deletions src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/PresentationFramework.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -984,8 +984,8 @@ public enum MessageBoxButton
OK = 0,
OKCancel = 1,
RetryCancel = 5,
YesNoCancel = 3,
YesNo = 4,
YesNoCancel = 3,
}
public enum MessageBoxImage
{
Expand Down Expand Up @@ -2067,7 +2067,7 @@ public Window() { }
[System.ComponentModel.TypeConverterAttribute(typeof(System.Windows.ThemeModeConverter))]
[System.Diagnostics.CodeAnalysis.ExperimentalAttribute("WPF0001")]
public System.Windows.ThemeMode ThemeMode { get { throw null; } set { } }

[System.Windows.LocalizabilityAttribute(System.Windows.LocalizationCategory.Title)]
public string Title { get { throw null; } set { } }
[System.ComponentModel.TypeConverterAttribute("System.Windows.LengthConverter, PresentationFramework, Version=4.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, Custom=null")]
Expand Down
0