10000 [StyleCleanUp] Use ArgumentOutOfRangeException throw helper (CA1512) by h3xds1nz · Pull Request #10675 · dotnet/wpf · GitHub
[go: up one dir, main page]
Skip to content
/ wpf Public

[StyleCleanUp] Use ArgumentOutOfRangeException throw helper (CA1512) #10675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2025
Merged

[StyleCleanUp] Use ArgumentOutOfRangeException throw helper (CA1512) #10675

merged 1 commit into from
May 12, 2025

Conversation

h3xds1nz
Copy link
Member
@h3xds1nz h3xds1nz commented Mar 30, 2025 •
edited by dotnet-policy-service bot
Loading

Fixes #10674

Description

Fixes the leftover violations via suppressions as there's currently a bug I've described in dotnet/roslyn-analyzers#7617. To be honest, Duration could simply implement IEquatable<T>/IComparable<T>.

Customer Impact

Cleaner codebase for developers.

Regression

No.

Testing

Local build.

Risk

None.

Microsoft Reviewers: Open in CodeFlow

@h3xds1nz h3xds1nz requested review from a team as code owners March 30, 2025 16:35
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Mar 30, 2025
@codecov Codecov
Copy link
codecov bot commented Mar 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.90546%. Comparing base (2ded801) to head (cac1041).
Report is 76 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #10675         +/-   ##
===================================================
- Coverage   10.95887%   10.90546%   -0.05341%     
===================================================
  Files           3310        3310                 
  Lines         664667      664667                 
  Branches       74667       74667                 
===================================================
- Hits           72840       72485        -355     
- Misses        590685      591049        +364     
+ Partials        1142        1133          -9
Flag Coverage Δ
Debug 10.90546% <ø> (-0.05341%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@h3xds1nz
Copy link
Member Author
h3xds1nz commented Apr 4, 2025

Rebased now that the null record was removed.

@dipeshmsft dipeshmsft merged commit ac5efa2 into dotnet:main May 12, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipeshmsft dipeshmsft dipeshmsft approved these changes

@singhashish-wpf singhashish-wpf Awaiting requested review from singhashish-wpf

@Kuldeep-MS Kuldeep-MS Awaiting requested review from Kuldeep-MS

Assignees

@h3xds1nz h3xds1nz

Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CA1512: Use ArgumentOutOfRangeException throw helper
2 participants
@h3xds1nz @dipeshmsft
0