8000 [StyleCleanUp] Address IDE warnings Part 3 by harshit7962 · Pull Request #10188 · dotnet/wpf · GitHub
[go: up one dir, main page]
Skip to content

[StyleCleanUp] Address IDE warnings Part 3 #10188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 30, 2025
Merged

[StyleCleanUp] Address IDE warnings Part 3 #10188

merged 5 commits into from
Jan 30, 2025

Conversation

harshit7962
Copy link
Member
@harshit7962 harshit7962 commented Dec 17, 2024 •
edited by dotnet-policy-service bot
Loading

Description

This work is a part of our initiative to set code-style guidelines, align WPF and WinForms, and ensure PR standards with respect to styles. This in turn will help us in better maintainability and readability of the repo overall. The changes follow up from the PR #10080 and references to the issue #10017.

The current changes addresses the following Errors/Warnings in the src folder of WPF:

  • IDE0030: Null check can be simplified
  • IDE0031: Use null propagation

A good way to go about reviewing this is to go commit by commit which pans over individual errors/warnings, and hence easing out the overall understanding.

Customer Impact

None

Regression

None

Testing

Local Build Pass
Will be taken in the next test pass

Microsoft Reviewers: Open in CodeFlow

@harshit7962 harshit7962 requested review from a team as code owners December 17, 2024 13:38
@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Dec 17, 2024
10000
himgoyalmicro
himgoyalmicro previously approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor
@himgoyalmicro himgoyalmicro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

himgoyalmicro
himgoyalmicro previously approved these changes Jan 30, 2025
View reviewed changes
@himgoyalmicro himgoyalmicro merged commit 36e6e74 into dotnet:main Jan 30, 2025
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@himgoyalmicro himgoyalmicro himgoyalmicro approved these changes

@dipeshmsft dipeshmsft Awaiting requested review from dipeshmsft

@singhashish-wpf singhashish-wpf Awaiting requested review from singhashish-wpf

@Kuldeep-MS Kuldeep-MS Awaiting requested review from Kuldeep-MS

Assignees

@harshit7962 harshit7962

Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshit7962 @himgoyalmicro
0