8000 [StyleCleanUp] Addressing SA warnings Part 4 by harshit7962 · Pull Request #10126 · dotnet/wpf · GitHub
[go: up one dir, main page]
Skip to content

[StyleCleanUp] Addressing SA warnings Part 4 #10126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 2, 2025
Merged

[StyleCleanUp] Addressing SA warnings Part 4 #10126

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3a771c2
Update: Resolve SA1129 in src
harshit7962 Nov 27, 2024
04ff75a
Update: Resolve SA1121 in src
harshit7962 Nov 27, 2024
abc1640
Update: Resolve SA1028 in src
harshit7962 Nov 27, 2024
59d064f
Update: Resolve SA1027 in src
harshit7962 Nov 27, 2024
96f5326
Update: Resolve SA1014 in src
harshit7962 Nov 27, 2024
60bc61a
Update: Resolve SA1005 in src
harshit7962 Nov 27, 2024
42dfc3b
Update: Resolve SA1001 in src
harshit7962 Nov 8000 27, 2024
e571f80
Merge branch 'main' into editorconfigCleanup4
harshit7962 Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update: Resolve SA1028 in src
  • Loading branch information
@harshit7962
harshit7962 committed Nov 27, 2024
commit abc16401f8e5afadfdda396551e19641df0fa905
3 changes: 0 additions & 3 deletions src/Microsoft.DotNet.Wpf/src/.editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,9 +308,6 @@ dotnet_diagnostic.SA1014.severity = suggestion
# SA1027: Tabs and spaces should be used correctly
dotnet_diagnostic.SA1027.severity = suggestion

# SA1028: Code should not contain trailing whitespace
dotnet_diagnostic.SA1028.severity = suggestion

# SA1131: Constant values should appear on the right-hand side of comparisons
dotnet_diagnostic.SA1131.severity = suggestion

Expand Down
6 changes: 3 additions & 3 deletions src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Runtime/DynamicMethodRuntime.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ private DelegateCreator CreateDelegateCreatorWithoutHelper()

private FactoryDelegate CreateFactoryDelegate(ConstructorInfo ctor)
{
DynamicMethod dynamicMethod = CreateDynamicMethod($"{ctor.DeclaringType.Name}Ctor",
DynamicMethod dynamicMethod = CreateDynamicMethod($"{ctor.DeclaringType.Name}Ctor",
typeof(object), typeof(object[]));
ILGenerator ilGenerator = dynamicMethod.GetILGenerator();

Expand All @@ -329,7 +329,7 @@ private FactoryDelegate CreateFactoryDelegate(ConstructorInfo ctor)

private FactoryDelegate CreateFactoryDelegate(MethodInfo factory)
{
DynamicMethod dynamicMethod = CreateDynamicMethod($"{factory.Name}Factory",
DynamicMethod dynamicMethod = CreateDynamicMethod($"{factory.Name}Factory",
typeof(object), typeof(object[]));
ILGenerator ilGenerator = dynamicMethod.GetILGenerator();

Expand Down Expand Up @@ -407,7 +407,7 @@ private void UnloadArguments(ILGenerator ilGenerator, LocalBuilder[] locals)
// Note that CreateGetDelegate fails verification for value types (and probably shouldn't)
private PropertyGetDelegate CreateGetDelegate(MethodInfo getter)
{
DynamicMethod dynamicMethod = CreateDynamicMethod($"{getter.Name}Getter",
DynamicMethod dynamicMethod = CreateDynamicMethod($"{getter.Name}Getter",
typeof(object), typeof(object));
ILGenerator ilGenerator = dynamicMethod.GetILGenerator();

Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/XamlReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public virtual void Skip()
#region IDisposable

// See Framework Design Guidelines, pp. 248-260.

void IDisposable.Dispose()
{
Dispose(true);
Expand Down
0