8000 [Cleanup] Use named arguments in System.Xaml by ThomasGoulet73 · Pull Request #10061 · dotnet/wpf · GitHub
[go: up one dir, main page]
Skip to content

[Cleanup] Use named arguments in System.Xaml #10061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2024
Merged

[Cleanup] Use named arguments in System.Xaml #10061

merged 1 commit into from
Dec 30, 2024

Conversation

ThomasGoulet73
Copy link
Contributor
@ThomasGoulet73 ThomasGoulet73 commented Nov 13, 2024 •
edited by dotnet-policy-service bot
Loading

Contributes to #10018

Description

I replaced comments specifying an argument name with named arguments, which were introduced in C# 7. This improves readability and maintainability.

Note: The compiled IL is identical.

Customer Impact

None.

Regression

No.

Testing

Local build + validated IL.

Risk

Low to none.

Microsoft Reviewers: Open in CodeFlow

@ThomasGoulet73 ThomasGoulet73 requested review from a team as code owners November 13, 2024 00:21
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Nov 13, 2024
lindexi
lindexi approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member
@lindexi lindexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeremyKuhne JeremyKuhne mentioned this pull request Nov 16, 2024
Open
@himgoyalmicro himgoyalmicro self-assigned this Dec 10, 2024
@ThomasGoulet73 ThomasGoulet73 changed the title Cleanup: Use named arguments in System.Xaml [Cleanup] Use named arguments in System.Xaml Dec 17, 2024
himgoyalmicro
himgoyalmicro previously approved these changes Dec 18, 2024
View reviewed changes
@himgoyalmicro
Copy link
Contributor

LGTM. We have included it in test pass, and I will have the result soon.
Meanwhile, @ThomasGoulet73 Can you please resolve the merge conflicts?

@ThomasGoulet73 ThomasGoulet73 force-pushed the cleanup-use-named-arguments-in-System.Xaml branch from ebae0b1 to f9066f0 Compare December 20, 2024 05:21
@ThomasGoulet73
Copy link
Contributor Author

Done.

8000
@himgoyalmicro himgoyalmicro merged commit e9bc60b into dotnet:main Dec 30, 2024
8 checks passed
@himgoyalmicro
Copy link
Contributor

Thank you @ThomasGoulet73 for your contribution 😄

@ThomasGoulet73
Copy link
Contributor Author

Thanks

@ThomasGoulet73 ThomasGoulet73 deleted the cleanup-use-named-arguments-in-System.Xaml branch December 30, 2024 20:04
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lindexi lindexi lindexi approved these changes

@himgoyalmicro himgoyalmicro himgoyalmicro approved these changes

@dipeshmsft dipeshmsft Awaiting requested review from dipeshmsft

@singhashish-wpf singhashish-wpf Awaiting requested review from singhashish-wpf

@Kuldeep-MS Kuldeep-MS Awaiting requested review from Kuldeep-MS

Assignees

@ThomasGoulet73 ThomasGoulet73

@himgoyalmicro himgoyalmicro

Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ThomasGoulet73 @himgoyalmicro @lindexi @harshit7962
0