Enable nullability in ToolStripLabel #8000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreddy-work
reviewed
Oct 22, 2022
| @@ -33,27 +32,33 @@ public ToolStripLabel() | |||
| { | |||
| } | |||
|
|
|||
| public ToolStripLabel(string text) : base(text, null, null) | |||
| public ToolStripLabel(string? text) | |||
| : base(text, null, null) | |||
There was a problem hiding this comment.
nit: would be great if you add parameter names for null constants.
ghost
removed
the
waiting-author-feedback
The team requires more information from the author
label
Oct 23, 2022
e0e9737 to
22a4cf0
Compare
dreddy-work
approved these changes
Oct 23, 2022
RussKie
approved these changes
Oct 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Microsoft Reviewers: Open in CodeFlow