8000 Add code coverage for ToolStripCustomTypeDescriptor by Zheng-Li01 · Pull Request #12963 · dotnet/winforms · GitHub
[go: up one dir, main page]
Skip to content

Add code coverage for ToolStripCustomTypeDescriptor #12963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 22, 2025
Merged

Add code coverage for ToolStripCustomTypeDescriptor #12963

merged 6 commits into from
Feb 22, 2025

Conversation

Zheng-Li01
Copy link
Member
@Zheng-Li01 Zheng-Li01 commented Feb 17, 2025 •
edited by dotnet-policy-service bot
Loading

Related #10773

Proposed changes

Add unit test file: ToolStripCustomTypeDescriptorTests.cs for public methods of the ToolStripCustomTypeDescriptor.cs.
Enable nullability in ToolStripCustomTypeDescriptorTests.cs.

Microsoft Reviewers: Open in CodeFlow

@Zheng-Li01 Zheng-Li01 requested a review from a team as a code owner February 17, 2025 06:41
@codecov Codecov
Copy link
codecov bot commented Feb 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.02110%. Comparing base (12d120b) to head (76dcdba).
Report is 43 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #12963         +/-   ##
===================================================
+ Coverage   75.97906%   76.02110%   +0.04204%     
===================================================
  Files           3265        3268          +3     
  Lines         643272      643495        +223     
  Branches       47426       47433          +7     
===================================================
+ Hits          488752      489192        +440     
+ Misses        150962      150734        -228     
- Partials        3558        3569         +11
Flag Coverage Δ
Debug 76.02110% <100.00000%> (+0.04204%) ⬆️
integration 18.02859% <ø> (+0.01220%) ⬆️
production 49.97680% <ø> (+0.10118%) ⬆️
test 96.93657% <100.00000%> (-0.01777%) ⬇️
unit 47.41196% <ø> (+0.07856%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Feb 17, 2025
LeafShi1
LeafShi1 reviewed Feb 17, 2025
View reviewed changes
Copy link
Member
@LeafShi1 LeafShi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a little suggestion!

Copilot
Copilot AI reviewed Feb 18, 2025
View reviewed changes
Copy link
Contributor
@Copilot Copilot AI left a comment
8000

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

ricardobossan
ricardobossan requested changes Feb 18, 2025
View reviewed changes
Copy link
Member
@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please implement the IDisposable interface in the test class and dispose of the field.

ricardobossan
ricardobossan previously approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member
@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ricardobossan ricardobossan removed the waiting-review This item is waiting on review by one or more members of team label Feb 19, 2025
Tanya-Solyanik
Tanya-Solyanik reviewed Feb 19, 2025
View reviewed changes
Copy link
Contributor
@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some minor comments

@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Feb 19, 2025
@Zheng-Li01 Zheng-Li01 added waiting-review This item is waiting on review by one or more members of team and removed waiting-author-feedback The team requires more information from the author labels Feb 20, 2025
ricardobossan
ricardobossan approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member
@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit e8d0385 into dotnet:main Feb 22, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview3 milestone Feb 22, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Feb 22, 2025
@LeafShi1 LeafShi1 mentioned this pull request Feb 25, 2025
Open
@Zheng-Li01 Zheng-Li01 deleted the Add_code_coverage_for_ToolStripCollectionEditor branch February 27, 2025 07:08
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LeafShi1 LeafShi1 LeafShi1 left review comments

Copilot code review Copilot Copilot left review comments

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik approved these changes

@ricardobossan ricardobossan ricardobossan approved these changes

Assignees

@Zheng-Li01 Zheng-Li01

Labels
None yet
Projects
None yet
Milestone
10.0 Preview3
Development

Successfully merging this pull request may close these issues.
4 participants
@Zheng-Li01 @Tanya-Solyanik @ricardobossan @LeafShi1
0