8000 Add code coverage for ToolStripCollectionEditor.cs file by Olina-Zhang · Pull Request #12962 · dotnet/winforms · GitHub
[go: up one dir, main page]
Skip to content

Add code coverage for ToolStripCollectionEditor.cs file #12962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 19, 2025
Merged

Add code coverage for ToolStripCollectionEditor.cs file #12962

merged 4 commits into from
Feb 19, 2025

Conversation

Olina-Zhang
Copy link
Member
@Olina-Zhang Olina-Zhang commented Feb 17, 2025 •
edited by dotnet-policy-service bot
Loading

Related #10773

Proposed changes

  • Add unit test file: ToolStripCollectionEditorTests.cs for public methods of the ToolStripCollectionEditor.cs.
  • Enable nullability in ToolStripCollectionEditorTests.cs.
Microsoft Reviewers: Open in CodeFlow

@Olina-Zhang Olina-Zhang requested a review from a team as a code owner February 17, 2025 06:18
@codecov Codecov
Copy link
codecov bot commented Feb 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.75000% with 53 lines in your changes missing coverage. Please review.

Project coverage is 76.00771%. Comparing base (8ef1b9c) to head (3bc6112).
Report is 17 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #12962         +/-   ##
===================================================
+ Coverage   75.97321%   76.00771%   +0.03450%     
===================================================
  Files           3265        3266          +1     
  Lines         643286      643436        +150     
  Branches       47431       47436          +5     
===================================================
+ Hits          488725      489061        +336     
+ Misses        150991      150812        -179     
+ Partials        3570        3563          -7
Flag Coverage Δ
Debug 76.00771% <33.75000%> (+0.03450%) ⬆️
integration 18.03035% <ø> (+0.01818%) ⬆️
production 49.95360% <ø> (+0.08793%) ⬆️
test 96.93597% <33.75000%> (-0.01723%) ⬇️
unit 47.41049% <ø> (+0.08548%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copilot
Copilot AI reviewed Feb 18, 2025
View reviewed changes
Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

ricardobossan
ricardobossan reviewed Feb 18, 2025
View reviewed changes
Copy link
Member
@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than colleague's comment, all LGTM!

ricardobossan
ricardobossan previously approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member
@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ricardobossan ricardobossan added the waiting-author-feedback The team requires more information from the author label Feb 19, 2025
@ricardobossan ricardobossan dismissed their stale review February 19, 2025 00:59

New comments need to be addressed.

@Olina-Zhang Olina-Zhang removed the waiting-author-feedback The team requires more information from the author label Feb 19, 2025
ricardobossan
ricardobossan approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member
@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Tanya-Solyanik
Tanya-Solyanik approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor
@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit bcaed52 into dotnet:main Feb 19, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview3 milestone Feb 19, 2025
@Olina-Zhang Olina-Zhang deleted the UnitTest_ToolStripCollectionEditor branch February 20, 2025 01:30
@LeafShi1 LeafShi1 mentioned this pull request Feb 25, 2025
Open
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LeafShi1 LeafShi1 LeafShi1 left review comments

Copilot code review Copilot Copilot left review comments

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik approved these changes

@ricardobossan ricardobossan ricardobossan approved these changes

Assignees

@Olina-Zhang Olina-Zhang

Labels
None yet
Projects
None yet
Milestone
10.0 Preview3
Development

Successfully merging this pull request may close these issues.
4 participants
@Olina-Zhang @Tanya-Solyanik @ricardobossan @LeafShi1
0