Add code coverage for ListBoxSelectedObjectCollection #12952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12952 +/- ##
===================================================
- Coverage 76.08036% 75.99080% -0.08957%
===================================================
Files 3255 3265 +10
Lines 642192 643391 +1199
Branches 47295 47433 +138
===================================================
+ Hits 488582 488918 +336
- Misses 150056 150911 +855
- Partials 3554 3562 +8
Flags with carried forward coverage won't be shown. Click here to find out more. |
....Windows.Forms/tests/UnitTests/System/Windows/Forms/ListBox.SelectedObjectCollectionTests.cs
Outdated
Show resolved
Hide resolved
....Windows.Forms/tests/UnitTests/System/Windows/Forms/ListBox.SelectedObjectCollectionTests.cs
Outdated
Show resolved
Hide resolved
....Windows.Forms/tests/UnitTests/System/Windows/Forms/ListBox.SelectedObjectCollectionTests.cs
Outdated
Show resolved
Hide resolved
....Windows.Forms/tests/UnitTests/System/Windows/Forms/ListBox.SelectedObjectCollectionTests.cs
Show resolved
Hide resolved
Comment on lines
27
to
28
| public void ListBoxSelectedObjectCollection_Ctor_ListBox() => | ||
| Assert.True(_collection.IsReadOnly); |
There was a problem hiding this comment.
When breaking an expression-bodied method into multiple lines, please place the arrow operator on the line below, directly before the method body.
This happens in other methods as well.
There was a problem hiding this comment.
@ricardobossan @Zheng-Li01 - Actually the style guide is the other way around - https://github.com/dotnet/winforms/blob/main/docs/coding-style.md#line-breaks
There was a problem hiding this comment.
Thanks for the clarification, @Tanya-Solyanik! I had read the style guide before but got the formatting mixed up. I’ll make sure to follow the right approach going forward.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #10453
Proposed changes
Add unit tests for ListBox.SelectedObjectCollection.cs to test its methods
Microsoft Reviewers: Open in CodeFlow