8000 Add unit tests for ToolStripPanelDesigner by Nora-Zhou01 · Pull Request #12922 · dotnet/winforms · GitHub
[go: up one dir, main page]
Skip to content

Add unit tests for ToolStripPanelDesigner #12922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 26, 2025
Merged

Add unit tests for ToolStripPanelDesigner #12922

merged 6 commits into from
Feb 26, 2025

Conversation

Nora-Zhou01
Copy link
Contributor
@Nora-Zhou01 Nora-Zhou01 commented Feb 12, 2025 •
edited by dotnet-policy-service bot
Loading

Related #10773

Proposed changes

  • Add unit test ToolStripPanelDesignerTests.cs for public properties and method of the ToolStripPanelDesigner
  • Enable nullability in ToolStripPanelDesignerTests.cs
Microsoft Reviewers: Open in CodeFlow

@Nora-Zhou01 Nora-Zhou01 requested a review from a team as a code owner February 12, 2025 02:43
@codecov Codecov
Copy link
codecov bot commented Feb 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.31250% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.05796%. Comparing base (e91e3bc) to head (7604e8e).
Report is 330 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #12922         +/-   ##
===================================================
+ Coverage   75.75455%   76.05796%   +0.30340%     
===================================================
  Files           3159        3253         +94     
  Lines         635942      643245       +7303     
  Branches       46987       47398        +411     
===================================================
+ Hits          481755      489239       +7484     
+ Misses        150726      150452        -274     
- Partials        3461        3554         +93
Flag Coverage Δ
Debug 76.05796% <95.31250%> (+0.30340%) ⬆️
integration 18.01354% <ø> (-0.16124%) ⬇️
production 50.01275% <ø> (+0.69519%) ⬆️
test 96.93697% <95.31250%> (-0.10810%) ⬇️
unit 47.44439% <ø> (+0.91268%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copilot
Copilot AI reviewed Feb 13, 2025
View reviewed changes
ricardobossan
ricardobossan requested changes Feb 13, 2025
View reviewed changes
ricardobossan
ricardobossan requested changes Feb 18, 2025
View reviewed changes
ricardobossan
ricardobossan previously approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member
@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Update
< 6D47 /div>
7604e8e
@LeafShi1 LeafShi1 mentioned this pull request Feb 25, 2025
Open
Tanya-Solyanik
Tanya-Solyanik approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor
@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit ce05d71 into dotnet:main Feb 26, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview3 milestone Feb 26, 2025
LeafShi1 pushed a commit to LeafShi1/winforms that referenced this pull request Mar 6, 2025
@Nora-Zhou01 @LeafShi1
Add unit tests for ToolStripPanelDesigner (dotnet#12922)
f3476c2 
Related dotnet#10773

Proposed changes
Add unit test ToolStripPanelDesignerTests.cs for public properties and method of the ToolStripPanelDesigner
Enable nullability in ToolStripPanelDesignerTests.cs
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LeafShi1 LeafShi1 LeafShi1 left review comments

Copilot code review Copilot Copilot left review comments

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik approved these changes

@ricardobossan ricardobossan ricardobossan approved these changes

Assignees

@Nora-Zhou01 Nora-Zhou01

Labels
None yet
Projects
None yet
Milestone
10.0 Preview3
Development

Successfully merging this pull request may close these issues.
4 participants
@Nora-Zhou01 @Tanya-Solyanik @ricardobossan @LeafShi1
0