Marking classes as serializable to fix the Broadcast serialization issue

dotnet · Niharikadutta · Apr 20, 2020 · Apr 20, 2020 · May 6, 2020 · May 7, 2020
commit f564495fe0a770d8314f0ea54802eb1a28bb40e7
diff --git a/src/csharp/Microsoft.Spark/Interop/Ipc/JvmObjectReference.cs b/src/csharp/Microsoft.Spark/Interop/Ipc/JvmObjectReference.cs
@@ -112,6 +112,7 @@ internal interface IJvmObjectReferenceProvider
     /// <summary>
     /// Reference to object created in JVM.
     /// </summary>
+    [Serializable]
     internal sealed class JvmObjectReference : IJvmObjectReferenceProvider
     {
         /// <summary>

diff --git a/src/csharp/Microsoft.Spark/SparkConf.cs b/src/csharp/Microsoft.Spark/SparkConf.cs
@@ -17,6 +17,7 @@ namespace Microsoft.Spark
     /// Note that once a SparkConf object is passed to Spark, it is cloned and can no longer be
     /// modified by the user. Spark does not support modifying the configuration at runtime.
     /// </remarks>
+    [Serializable]
     public sealed class SparkConf : IJvmObjectReferenceProvider
     {
         private readonly JvmObjectReference _jvmObject;

diff --git a/src/csharp/Microsoft.Spark/SparkContext.cs b/src/csharp/Microsoft.Spark/SparkContext.cs
@@ -2,6 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+using System;
 using System.Collections.Generic;
 using System.IO;
 using System.Runtime.Serialization.Formatters.Binary;
@@ -18,6 +19,7 @@ namespace Microsoft.Spark
     /// Only one `SparkContext` should be active per JVM. You must `stop()` the
     /// active `SparkContext` before creating a new one.
     /// </summary>
+    [Serializable]
     public sealed class SparkContext : IJvmObjectReferenceProvider
     {
         private readonly JvmObjectReference _jvmObject;

diff --git a/src/csharp/Microsoft.Spark/Sql/Catalog/Catalog.cs b/src/csharp/Microsoft.Spark/Sql/Catalog/Catalog.cs
@@ -2,13 +2,15 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+using System;
 using Microsoft.Spark.Interop.Ipc;
 
 namespace Microsoft.Spark.Sql.Catalog
 {
     /// <summary>
     /// Catalog interface for Spark. To access this, use SparkSession.Catalog.
     /// </summary>
+    [Serializable]
     public sealed class Catalog : IJvmObjectReferenceProvider
     {
         private readonly JvmObjectReference _jvmObject;

diff --git a/src/csharp/Microsoft.Spark/Sql/SparkSession.cs b/src/csharp/Microsoft.Spark/Sql/SparkSession.cs
@@ -17,6 +17,7 @@ namespace Microsoft.Spark.Sql
     /// <summary>
     /// The entry point to programming Spark with the Dataset and DataFrame API.
     /// </summary>
+    [Serializable]
     public sealed class SparkSession : IDisposable, IJvmObjectReferenceProvider
     {
         private readonly JvmObjectReference _jvmObject;