8000 [main] Source code updates from dotnet/dotnet by dotnet-maestro[bot] · Pull Request #1247 · dotnet/source-build-reference-packages · GitHub
[go: up one dir, main page]
Skip to content

[main] Source code updates from dotnet/dotnet #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 6, 2025
Merged

[main] Source code updates from dotnet/dotnet #1247

merged 5 commits into from
May 6, 2025

Conversation

dotnet-maestro[bot]
Copy link
Contributor
@dotnet-maestro dotnet-maestro bot commented May 6, 2025

Note

This is a codeflow update. It may contain both source code changes from the VMR as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/dotnet

Updated Dependencies

@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner May 6, 2025 02:02
@ViktorHofer
Copy link
Member
ViktorHofer commented May 6, 2025 •
edited
Loading

Hmm, @dotnet/source-build do you understand the failures here? Just want to make sure that I didn't regress anything around the source-build yml. Edit: Hmm ok looks more like a GenAPI change.

@MichaelSimons
Copy link
Member

Hmm, @dotnet/source-build do you understand the failures here? Just want to make sure that I didn't regress anything around the source-build yml. Edit: Hmm ok looks more like a GenAPI change.

This looks to be the result of dotnet/sdk#46425 which appears to be flowing in with this PR. The blank lines that previously existed between the members and properties have been removed. @carlossanlop to confirm the behavior change. If this is the case, all packages should be regenerated while preserving the customizations that exist. I can do this but would like confirmation from @carlossanlop first.

@ViktorHofer
Copy link
Member

@carlossanlop to confirm the behavior change. If this is the case, all packages should be regenerated while preserving the customizations that exist. I can do this but would like confirmation from @carlossanlop first.

I remember, yes. We discussed this. Carlos fixed the code styling that caused the additional new lines.

@MichaelSimons
Copy link
Member

I remember, yes. We discussed this. Carlos fixed the code styling that caused the additional new lines.

Thanks for confirming. I will regenerate the packages. It will be later today as I have some other tasks to attend to first.

This was referenced May 6, 2025
Open
Open
@MichaelSimons MichaelSimons merged commit df3a4ab into main May 6, 2025
9 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-main-8bda9e75-40bc-4d69-825e-a0aa154c120f branch May 6, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmitche mmitche mmitche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ViktorHofer @MichaelSimons @mmitche
0