8000 Update build container for public CI by NikolaMilosavljevic · Pull Request #1233 · dotnet/source-build-reference-packages · GitHub
[go: up one dir, main page]
Skip to content

Update build container for public CI #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

Update build container for public CI #1233

merged 1 commit into from
Apr 23, 2025

Conversation

NikolaMilosavljevic
Copy link
Member

Ubuntu.1804 is EOL. Updating the container to Ubuntu.2204

@NikolaMilosavljevic NikolaMilosavljevic requested a review from a team as a code owner April 23, 2025 17:53
MichaelSimons
MichaelSimons reviewed Apr 23, 2025
View reviewed changes
azure-pipelines/templates/stages/build.yml
@@ -9,7 +9,7 @@ stages:
pool:
${{ if eq(variables['System.TeamProject'], 'public') }}:
name: $(DncEngPublicBuildPool)
demands: ImageOverride -equals Build.Ubuntu.1804.Amd64.Open
demands: ImageOverride -equals Build.Ubuntu.2204.Amd64.Open
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 2404 available? If so it would be desirable to upgrade to it as 2204 will reach EOL before .NET10.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like 2204 is all that is available. That is unfortunate.

Copy link
Member Author
@NikolaMilosavljevic NikolaMilosavljevic Apr 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see 24.04 in use by any repo, the image is likely not available. Will inquire.

@akoeplinger akoeplinger merged commit aa2a3f5 into dotnet:main Apr 23, 2025
4 checks passed
akoeplinger pushed a commit that referenced this pull request Apr 23, 2025
@NikolaMilosavljevic @akoeplinger
Update build container for public CI (#1233)
4059045 
(cherry picked from commit aa2a3f5)
@NikolaMilosavljevic
Copy link
Member Author

/backport to release/9.0

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/9.0: https://github.com/dotnet/source-build-reference-packages/actions/runs/14625957634

@github-actions GitHub Actions
Copy link
Contributor

@NikolaMilosavljevic an error occurred while backporting to "release/9.0", please check the run log for details!

Validation Failed: {"resource":"PullRequest","code":"custom","message":"No commits between release/9.0 and backport/pr-1233-to-release/9.0"}

@NikolaMilosavljevic
Copy link
Member Author

@NikolaMilosavljevic an error occurred while backporting to "release/9.0", please check the run log for details!

Validation Failed: {"resource":"PullRequest","code":"custom","message":"No commits between release/9.0 and backport/pr-1233-to-release/9.0"}

It looks like 9.0 would require a manual backport - will prepare the PR.

@MichaelSimons
Copy link
Member

It looks like 9.0 would require a manual backport - will prepare the PR.

See #1232 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelSimons MichaelSimons MichaelSimons approved these changes

@mthalman mthalman mthalman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NikolaMilosavljevic @MichaelSimons @mthalman @akoeplinger
0