8000 Repo infrastructure improvements & UseInnerClone by ViktorHofer · Pull Request #478 · dotnet/source-build-externals · GitHub
[go: up one dir, main page]
Skip to content

Repo infrastructure improvements & UseInnerClone #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2025
Merged

Repo infrastructure improvements & UseInnerClone #478

merged 2 commits into from
May 5, 2025

Conversation

ViktorHofer
Copy link
Member
@ViktorHofer ViktorHofer commented May 4, 2025 •
edited
Loading

Unblocks dotnet/dotnet#176

Commit 1: Infra improvements that makes it easier to enable inner clone directly in SBE

  • Build the tasks project as a dependency of the repo-projects and remove the serial build step in Build.props
  • Let the task project use the Arcade SDK and remove Arcade conditions from D.B files as it's always imported now.
  • Convert the task project's use of Newtonsoft.Json to System.Text.Json (thanks Copilot).
  • Remove a ton of dead properties, items and targets
  • Use the Microsoft.Build.NoTargets SDK in repo-projects projs (same as in the VMR) and define a dependency for it in global.json.
  • Remove reading the SDK version in build.sh and just read from the MSBuild property instead.
  • Make all repo-projects logging (binlogs + logs) go under artifacts\log\<config>\<repo>\ (same as in VMR)
  • Clean-up the semaphore infra for incremental builds by following the VMR model
  • Use standard Arcade.Sdk properties for DotNetTool and DotNetRoot

Commit 2: Enable inner-clone functionality in SBE and disable the ArPow UseInnerClone infra.

Instead of a clone of the entire SBE repository, clone the inner repos directly. The cloned repo folder is located under src\<repo>\artifacts\clone\.

I validated that after this change the produced packages still get correctly published under the ArtifactsShippingPackagesDir and the log files under the ArtifactsLogDir.

@ViktorHofer ViktorHofer force-pushed the UpdateSBE branch 4 times, most recently from 01d8b69 to e15ac61 Compare May 4, 2025 09:45
@ViktorHofer ViktorHofer changed the title Repo improvements Repo infrastructure improvements May 4, 2025
@ViktorHofer ViktorHofer marked this pull request as ready for review May 4, 2025 09:50
@ViktorHofer ViktorHofer requested a review from a team as a code owner May 4, 2025 09:50
@ViktorHofer ViktorHofer changed the title Repo infrastructure improvements Repo infrastructure improvements & UseInnerClone May 4, 2025
@ViktorHofer ViktorHofer mentioned this pull request May 4, 2025
Merged
11 tasks
@ViktorHofer
Copy link
Member Author
ViktorHofer commented May 5, 2025 •
edited
Loading

OK, prebuilt usage isn't yet working correctly. Looking... -> fixed

@NikolaMilosavljevic
Copy link
Member

@MichaelSimons @mthalman

MichaelSimons
MichaelSimons reviewed May 5, 2025
View reviewed changes
Copy link
Member
@MichaelSimons MichaelSimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@ViktorHofer ViktorHofer merged commit b668a5d into main May 5, 2025
2 checks passed
@ViktorHofer ViktorHofer deleted the UpdateSBE branch May 5, 2025 16:51
ViktorHofer
ViktorHofer commented May 5, 2025
View reviewed changes
eng/tasks/Microsoft.DotNet.SourceBuild.Tasks.XPlat/UpdateJson.cs
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that CoPilot removed the license header. Will bring that back in an eventual follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelSimons MichaelSimons MichaelSimons approved these changes

@NikolaMilosavljevic NikolaMilosavljevic Awaiting requested review from NikolaMilosavljevic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ViktorHofer @NikolaMilosavljevic @MichaelSimons
0