Exclude upstream files from Emscripten and code coverage #49186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
A PR to exclude specific upstream files related to Emscripten and code coverage from analysis by updating the analyzeTargetGlob patterns.
- Updated exclusion patterns in the SDK build pipeline YAML file.
- Added patterns to exclude files from Microsoft.NET.Runtime.Emscripten tools and CodeCoverage directories.
Comments suppressed due to low confidence (1)
eng/pipelines/templates/jobs/sdk-build.yml:61
- Ensure that the updated exclusion patterns do not inadvertently exclude intended files, and consider adding a comment to clarify the rationale for these exclusions.
analyzeTargetGlob: +:f|eng\**\*.props;+:f|artifacts\bin\**\*.dll;+:f|artifacts\bin\**\*.exe;-:f|artifacts\bin\**\msdia140.dll;-:f|artifacts\bin\**\pgort140.dll;-:f|artifacts\bin\*Tests\**;-f:|**\Microsoft.NET.Runtime.Emscripten**\tools\**.exe;-f:|**\CodeCoverage\**\*.*;
3 tasks
stan-sz
reviewed
Jun 2, 2025
| @@ -58,7 +58,7 @@ jobs: | |||
| templateContext: | |||
| sdl: | |||
| binskim: | |||
| analyzeTargetGlob: +:f|eng\**\*.props;+:f|artifacts\bin\**\*.dll;+:f|artifacts\bin\**\*.exe;-:f|artifacts\bin\**\msdia140.dll;-:f|artifacts\bin\**\pgort140.dll;-:f|artifacts\bin\*Tests\**; | |||
| analyzeTargetGlob: +:f|eng\**\*.props;+:f|artifacts\bin\**\*.dll;+:f|artifacts\bin\**\*.exe;-:f|artifacts\bin\**\msdia140.dll;-:f|artifacts\bin\**\pgort140.dll;-:f|artifacts\bin\*Tests\**;-f:|**\Microsoft.NET.Runtime.Emscripten**\tools\**.exe;-f:|**\CodeCoverage\**\*.*; | |||
There was a problem hiding this comment.
@marcpopMSFT which syntax is the correct one? This line has both -f:| and -:f|
There was a problem hiding this comment.
I only see -:f in the previous version unless you meant a different line?
There was a problem hiding this comment.
Previous line contains -:f, the new line contains -f:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.