[Blazor] Disable custom cache in .NET 10 #49183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR disables the custom caching mechanism in .NET 10 by updating MSBuild conditions to differentiate between target framework versions.
- Introduces new properties (_TargetingNETBefore80, _TargetingNET80OrLater, _TargetingNETBefore100, _TargetingNET100OrLater) to accurately detect framework versions.
- Updates the condition for BlazorCacheBootResources to disable caching on .NET 10 and later.
- Removes duplicate property group declarations to streamline the target file.
Comments suppressed due to low confidence (1)
src/BlazorWasmSdk/Targets/Microsoft.NET.Sdk.BlazorWebAssembly.6_0.targets:56
- Ensure that the condition effectively disables caching for .NET 10 and later as intended. Consider verifying the logic against future framework changes.
<BlazorCacheBootResources Condition="'$(BlazorCacheBootResources)' == '' and '$(_TargetingNET100OrLater)' != 'true'">true</BlazorCacheBootResources>
|
Thanks for your PR, @@maraf. |
javiercn
approved these changes
May 28, 2025
pavelsavara
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable custom cache in .NET 10 as we plan to completely remove it.
Contributes to dotnet/runtime#85775 and is required by dotnet/runtime#114901