8000 stop using System.CommandLine types that aren't public anymore by adamsitnik · Pull Request #49181 · dotnet/sdk · GitHub
[go: up one dir, main page]
Skip to content

stop using System.CommandLine types that aren't public anymore #49181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 3, 2025
Merged

stop using System.CommandLine types that aren't public anymore #49181

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
98001a0
don't use WithHelpDescription just to set custom description for an o…
adamsitnik May 28, 2025
58eca71
don't use WithHelpDescription just to set custom description for Glob…
adamsitnik May 28, 2025
d95f617
remove WithHelpDescription and the reason why it existed
adamsitnik May 28, 2025
3897299
don't customize a description of a command used in one place, just se…
adamsitnik May 28, 2025
d955427
stop using GetValue<T>(name) as it throws when given symbol was not p…
adamsitnik May 28, 2025
d30589a
bump BDN version
adamsitnik May 29, 2025
adf8a42
copy System.CommandLine.Help types that are no longer public and fix …
adamsitnik May 29, 2025
fa8d493
restore previous behavior of showing a shorter description of the ver…
adamsitnik May 29, 2025
8048757
update the expected completions
adamsitnik May 30, 2025
bc734c4
address code review feedback: use file-scoped namespace
adamsitnik Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
don't customize a description of a command used in one place, just se… 
…t the description to desired text
  • Loading branch information
@adamsitnik
adamsitnik committed May 28, 2025
commit 3897299ae249fafccbc11cb7e906bc7a627a823f
2 changes: 1 addition & 1 deletion src/Cli/dotnet/Commands/Workload/Search/WorkloadSearchVersionsCommandParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public static Command GetCommand()

private static Command ConstructCommand()
{
var command = new Command("version", CliCommandStrings.PrintSetVersionsDescription);
var command = new Command("version", CliStrings.ShortWorkloadSearchVersionDescription);
command.Arguments.Add(WorkloadVersionArgument);
command.Options.Add(FormatOption);
command.Options.Add(TakeOption);
Expand Down
9 changes: 1 addition & 8 deletions src/Cli/dotnet/Parser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ internal static int ExceptionHandler(Exception exception, ParseResult parseResul

return 1;
}

internal class DotnetHelpBuilder : HelpBuilder
{
private DotnetHelpBuilder(int maxWidth = int.MaxValue) : base(maxWidth) { }
Expand All @@ -273,16 +273,9 @@ private DotnetHelpBuilder(int maxWidth = int.MaxValue) : base(maxWidth) { }

DotnetHelpBuilder dotnetHelpBuilder = new(windowWidth);

SetHelpCustomizations(dotnetHelpBuilder);

return dotnetHelpBuilder;
});

private static void SetHelpCustomizations(HelpBuilder builder)
{
builder.CustomizeSymbol(WorkloadSearchVersionsCommandParser.GetCommand(), secondColumnText: CliStrings.ShortWorkloadSearchVersionDescription);
}

public static void additionalOption(HelpContext context)
{
List<TwoColumnHelpRow> options = [];
Expand Down
Loading
0