Allow build --no-restore for file-based programs
#49013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the handling of the "--no-restore" flag for file-based programs, allowing its use even when combined with NoCache. Key changes include:
- Renaming an existing test method from NoRestore to NoRestore_01.
- Adding a new test method NoRestore_02 that verifies behavior when no restore is performed before a build.
- Removing an exception in VirtualProjectBuildingCommand that previously disallowed the NoCache and NoRestore combination.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/dotnet.Tests/CommandTests/Run/RunFileTests.cs | Updates to test method naming and additional tests for "--no-restore" behavior |
| src/Cli/dotnet/Commands/Run/VirtualProjectBuildingCommand.cs | Removal of validation that threw on the NoCache + NoRestore combination |
Comments suppressed due to low confidence (2)
test/dotnet.Tests/CommandTests/Run/RunFileTests.cs:701
- [nitpick] Consider using a more descriptive test method name instead of 'NoRestore_01' to clearly indicate the scenario being validated. For example, include details about the expected behavior when a build is performed with '--no-restore' without a prior restore.
public void NoRestore_01()
test/dotnet.Tests/CommandTests/Run/RunFileTests.cs:733
- [nitpick] Consider using a more descriptive test method name instead of 'NoRestore_02' to convey the test scenario more clearly, such as emphasizing the sequential restore and build operations.
public void NoRestore_02()
chsienki
approved these changes
May 16, 2025
MiYanni
approved these changes
May 19, 2025
This was referenced Jun 9, 2025
To avoid unnecessary work in failure scenarios.
jaredpar
approved these changes
Jun 10, 2025
|
The failures are in watch tests, containers test, DotnetCliSnapshotTests, and a tool test that seems unrelated. Merging per request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously NoCache + NoRestore was disallowed, but there is actually no reason to disallow that combination. Also
dotnet build file.csimplicitly passes NoCache, hencedotnet build --no-restore file.csdidn't work.