Support binlog in build/restore of file-based programs #49009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for handling the "-bl" (binary log) argument for file-based programs during dotnet build and restore operations.
- Adds a new utility method to separate binary log arguments.
- Refactors command parsing in the Run, Restore, and Build commands to use the new utility.
- Updates test cases to validate the new behavior.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/dotnet.Tests/CommandTests/Run/RunFileTests.cs | Adds tests to validate binary log argument handling for build/restore commands. |
| src/Cli/dotnet/LoggerUtility.cs | Introduces a new method to separate binary log arguments from other arguments. |
| src/Cli/dotnet/Commands/Test/MSBuildUtility.cs | Refactors token separation using the new utility method. |
| src/Cli/dotnet/Commands/Run/RunCommand.cs | Updates binary log argument separation to improve consistency. |
| src/Cli/dotnet/Commands/Restore/RestoreCommand.cs | Adjusts processing of file arguments and binary log arguments for restore scenarios. |
| src/Cli/dotnet/Commands/Build/BuildCommand.cs | Similar refactoring and merging of binary log arguments during build command parsing. |
| @@ -61,6 +61,23 @@ private static FacadeLogger ConfigureDispatcher(List<BinaryLogger> binaryLoggers | |||
| return new FacadeLogger(dispatcher); | |||
| } | |||
|
|
|||
| internal static void SeparateBinLogArguments(IEnumerable<string>? args, out List<string> binLogArgs, out List<string> nonBinLogArgs) | |||
There was a problem hiding this comment.
[nitpick] Consider adding XML documentation comments for the SeparateBinLogArguments method to explain its behavior, especially the treatment of null inputs and the criteria used to separate binlog arguments.
Copilot uses AI. Check for mistakes.
chsienki
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this PR,
dotnet build -bl Program.csis not supported because both args (-blandProgram.cs) are treated as the "project file" argument (that's a pre-existing behavior, even for project-based programs, but for them all unknown arguments are forwarded to msbuild.exe, which we can't do when using msbuild APIs). This PR makes build/restore extract-blarguments just like thedotnet runcommand does.