Fix versioned sdk imports in file-based programs #49008
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the handling of versioned SDK imports by updating the import syntax both in test files and in the virtual project builder.
- Added a new test ("SdkReference") to verify correct SDK import handling.
- Updated XML import elements in test files and refactored XML generation in VirtualProjectBuildingCommand.cs to use a shared helper method.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/dotnet.Tests/CommandTests/Run/RunFileTests.cs | Added a new test to ensure SDK references load correctly and updated XML import syntax. |
| src/Cli/dotnet/Commands/Run/VirtualProjectBuildingCommand.cs | Refactored XML import creation with a new helper method to conditionally include the Version attribute. |
Comments suppressed due to low confidence (1)
test/dotnet.Tests/CommandTests/Run/RunFileTests.cs:980
- [nitpick] Verify that the indentation and newline handling in the triple-quoted string used for 'Program.cs' results in the exact XML formatting expected by the build command, as any extra whitespace might affect parsing.
File.WriteAllText(Path.Join(testInstance.Path, "Program.cs"), """
DamianEdwards
approved these changes
May 16, 2025
chsienki
approved these changes
May 16, 2025
jasonmalinowski
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48990.