8000 Fix Hot Reload profile detection for web apps by tmat · Pull Request #48909 · dotnet/sdk · GitHub
[go: up one dir, main page]
Skip to content

Fix Hot Reload profile detection for web apps #48909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 19, 2025
Merged

Fix Hot Reload profile detection for web apps #48909

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e3357aa
Fix Hot Reload profile detection for web apps
tmat May 13, 2025
26987ec
Improve error reporting
tmat May 13, 2025
7cbed28
Fix
tmat May 13, 2025
c0d5319
Fix
tmat May 13, 2025
a436672
Update src/BuiltInTools/dotnet-watch/Internal/IReporter.cs
tmat May 14, 2025
3824de3
Emoji consts
tmat May 16, 2025
a212df2
Merge remote-tracking branch 'refs/remotes/origin/FixProfileDetection…
tmat May 16, 2025
ad02b56
Emoji
tmat May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix
  • Loading branch information
@tmat
tmat committed May 13, 2025
commit 7cbed28ecfa44c96ae6418cfe55d2dc5349014d5
10 changes: 5 additions & 5 deletions src/BuiltInTools/dotnet-watch/Internal/IReporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public MessageDescriptor ToErrorWhen(bool condition)
public static readonly MessageDescriptor Exited = new("Exited", WatchEmoji, MessageSeverity.Output, s_id++);
public static readonly MessageDescriptor ExitedWithUnknownErrorCode = new("Exited with unknown error code", ErrorEmoji, MessageSeverity.Error, s_id++);
public static readonly MessageDescriptor ExitedWithErrorCode = new("Exited with error code {0}", ErrorEmoji, MessageSeverity.Error, s_id++);
public static readonly MessageDescriptor SkippingConfiguringBrowserRefresh_SuppressedViaEnvironmentVariable = new("kipping configuring browser-refresh middleware since its suppressed via environment variable {0}.", WatchEmoji, MessageSeverity.Verbose, s_id++);
public static readonly MessageDescriptor SkippingConfiguringBrowserRefresh_SuppressedViaEnvironmentVariable = new("kipping configuring browser-refresh middleware since its refresh server suppressed via environment variable {0}.", WatchEmoji, MessageSeverity.Verbose, s_id++);
public static readonly MessageDescriptor SkippingConfiguringBrowserRefresh_TargetFrameworkNotSupported = new("Skipping configuring browser-refresh middleware since the target framework version is not supported. For more information see 'https://aka.ms/dotnet/watch/unsupported-tfm'.", WatchEmoji, MessageSeverity.Warning, s_id++);
public static readonly MessageDescriptor SkippingConfiguringBrowserRefresh_NotWebApp = new("Skipping configuring browser-refresh middleware since this is not a webapp.", WatchEmoji, MessageSeverity.Verbose, s_id++);
}
Expand Down Expand Up @@ -116,16 +116,16 @@ public bool PrefixProcessOutput
void Report(MessageDescriptor descriptor, params object?[] args)
=> Report(descriptor, prefix: "", args);

void Verbose(string message, string emoji = WatchEmoji)
void Verbose(string message, string emoji = MessageDescriptor.WatchEmoji)
=> Report(new MessageDescriptor(message, emoji, MessageSeverity.Verbose, Id: null));

void Output(string message, string emoji = WatchEmoji)
void Output(string message, string emoji = MessageDescriptor.WatchEmoji)
=> Report(new MessageDescriptor(message, emoji, MessageSeverity.Output, Id: null));

void Warn(string message, string emoji = WatchEmoji)
void Warn(string message, string emoji = MessageDescriptor.WatchEmoji)
=> Report(new MessageDescriptor(message, emoji, MessageSeverity.Warning, Id: null));

void Error(string message, string emoji = ErrorEmoji)
void Error(string message, string emoji = MessageDescriptor.ErrorEmoji)
=> Report(new MessageDescriptor(message, emoji, MessageSeverity.Error, Id: null));
}
}
Loading
0