Unset CompilerType from Csc #48843
Open
Unset CompilerType from Csc #48843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR removes the CompilerType property from several MSBuild targets to unset the compiler type from Csc.
- Removed CompilerType from Microsoft.NET.Build.Tasks targets
- Removed CompilerType from Razor SDK Component targets
- Removed CompilerType from Razor SDK Compilation targets
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets | Removed CompilerType attribute from the build targets |
| src/RazorSdk/Targets/Microsoft.NET.Sdk.Razor.Component.targets | Removed CompilerType attribute from the Razor component targets |
| src/RazorSdk/Targets/Microsoft.NET.Sdk.Razor.Compilation.targets | Removed CompilerType attribute from the Razor compilation targets |
Comments suppressed due to low confidence (3)
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets:1237
- Consider updating the related documentation or release notes to explicitly mention the removal of the CompilerType property, ensuring that users understand this change.
CompilerType="$(RoslynCompilerType)"
src/RazorSdk/Targets/Microsoft.NET.Sdk.Razor.Component.targets:197
- Ensure that any documentation or internal comments referencing CompilerType in Razor component targets are updated to reflect its removal.
CompilerType="$(RoslynCompilerType)"
src/RazorSdk/Targets/Microsoft.NET.Sdk.Razor.Compilation.targets:131
- Verify that the removal of CompilerType in the Razor compilation targets is properly communicated through updated documentation or release notes.
CompilerType="$(RoslynCompilerType)"
chsienki
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.