Remove unnecessary CA2022 suppressions #48766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes unnecessary CA2022 suppression pragmas and updates the code to directly discard the result of Stream.ReadAsync to trigger a pipe state update.
- Removed CA2022 suppressions from both ConnectionHost.cs and Client.cs.
- Updated asynchronous read calls to assign the result to a discard.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/RazorSdk/Tool/ConnectionHost.cs | Removed warning suppressions and updated the read operation. |
| src/RazorSdk/Tool/Client.cs | Removed warning suppressions and updated the read operation. |
|
Thanks for your PR, @@Winniexu01. |
jjonescz
approved these changes
Apr 29, 2025
| #pragma warning disable CA2022 // Avoid inexact read | ||
| await Stream.ReadAsync(Array.Empty<byte>(), 0, 0, cancellationToken); | ||
| #pragma warning restore CA2022 | ||
| _ = await Stream.ReadAsync(Array.Empty<byte>(), 0, 0, cancellationToken); |
There was a problem hiding this comment.
Consider leaving comments explaining why we can't use ReadExactAsync so someone doesn't try to "fix" that in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#4322
Stream.ReadAsyncmethod.In the code, we need to trigger a state update on a
Pipestreamwithout actualy reading data. UsingStream.ReadExactlyAsyncwith a zero-length buffer will not update the state of the pipe: Remove unnecessary CA2022 suppressions #47904 (comment)