10000 Remove P3 entries and Windows arm & RHEL 6 rows by v-wuzhai · Pull Request #48648 · dotnet/sdk · GitHub
[go: up one dir, main page]

Skip to content

Remove P3 entries and Windows arm & RHEL 6 rows #48648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

v-wuzhai
Copy link
Member

No description provided.

@Copilot Copilot AI review requested due to automatic review settings April 23, 2025 02:03
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates .NET SDK documentation by changing version references from preview3 to preview4 to reflect an upgrade in the release cycle. Key changes include:

  • Updating the package table header from preview3 to preview4.
  • Revising all reference links for Windows, macOS, Linux, and ARM platforms to use the preview4 URLs.
  • Adjusting installer, badge, and checksum links accordingly.

@v-wuzhai v-wuzhai requested a review from marcpopMSFT April 23, 2025 05:44
@ViktorHofer
Copy link
Member
ViktorHofer commented Apr 23, 2025

@v-wuzhai going forward, we will need to make a similar change in the VMR's build table: https://github.com/dotnet/dotnet/blob/main/docs/builds-table.md

P4 is the first MSFT release that ships from the VMR. My assumption is that we will eventually delete the 10.0 entries from sdk's build table - maybe starting with P5.

cc @marcpopMSFT @mmitche

@marcpopMSFT
Copy link
Member

@ViktorHofer Does anything change about the table or is it just a duplicate of the existing table? Any concerns including 9.0.300 (at least briefly)?

@v-wuzhai can you creating a PR to update the table in the dotnet/dotnet repo? Can you update the script to remove the windows arm and RHEL 6 rows as those are empty now.

@ViktorHofer
Copy link
Member

Does anything change about the table or is it just a duplicate of the existing table? Any concerns including 9.0.300 (at least briefly)?

The VMR is mainly a .NET 10 and onwards thing. It's also the home for SB for 8.0.1xx and 9.0.1xx but those releases never had a build table. I wouldn't add entries pre .NET 10 to the VMR table.

Does anything change about the table or is it just a duplicate of the existing table?

It's not a 100% duplicate but it's mostly the same, yes. I.e. currently the links in it go to "10.0.1xx-ub" instead of "10.0.1xx". That will change eventually, maybe with P5.

@marcpopMSFT
Copy link
Member

Thanks. I didn't notice the -ub in the aka.ms link. v-wuzhai will make sure to handle that right for the dotnet/dotnet table update. We'll be removing 9.0.300 in a few weeks anyway and then once -ub goes away, they should be identical at that point it sounds like sometime during the summer.

@v-wuzhai
Copy link
Member Author
v-wuzhai commented Apr 24, 2025

@ViktorHofer I have already checked the build table. In the md file in the dotnet/dotnet repository, I found that the table in the main branch reflects the changes for P5. I tried to add the P4 column and use the links 10.0.1xx-preview4-ub and 10.0.1xx-ub-preview4, but neither worked.

Additionally, we can remove the P3 entries in this PR and also remove the Windows arm and RHEL 6 rows.

@v-wuzhai v-wuzhai changed the title Update NET10 P3 to P4 Remove P3 entries and Windows arm & RHEL 6 rows Apr 24, 2025
@ViktorHofer
Copy link
Member
ViktorHofer commented Apr 24, 2025

I tried to add the P4 column and use the links 10.0.1xx-preview4-ub and 10.0.1xx-ub-preview4, but neither worked.

It's possible that we don't have a P4 build produced by the VMR yet.

@v-wuzhai v-wuzhai closed this Apr 29, 2025
@ViktorHofer ViktorHofer deleted the dev/Jason/updateTable branch April 29, 2025 13:04
@marcpopMSFT
Copy link
Member

@v-wuzhai I got clarification on this. There is no -ub channel for preview 4 like there is for main. Right now both dotnet/dotnet and dotnet/sdk are publishing to the same aka.ms link for p4. For p5, it'll only be dotnet/dotnet and no dotnet/sdk. For now, we're just relying on the fact that the dotnet/dotnet build comes out later.

So plan for now
SDK: Remove arm and rhel 6 rows
SDK: Replace preview 3 with preview 4
dotnet/dotnet: add preview4 (the aka.ms links will be identical to the sdk preview 4 but main will be -ub links)

Plan for preview5
SDK: link to the dotnet/dotnet table
dotnet/dotnet: replace the main -ub links with the standard links
dotnet/dotnet: replace preview4 with preview5

After prevew5, if you could update the dotnet/dotnet repo as you did before for the sdk repo and we'll just link to them from the sdk repo main page. Make sense?

A9A4

@v-wuzhai
Copy link
Member Author
v-wuzhai commented May 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0