-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove P3 entries and Windows arm & RHEL 6 rows #48648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates .NET SDK documentation by changing version references from preview3 to preview4 to reflect an upgrade in the release cycle. Key changes include:
- Updating the package table header from preview3 to preview4.
- Revising all reference links for Windows, macOS, Linux, and ARM platforms to use the preview4 URLs.
- Adjusting installer, badge, and checksum links accordingly.
@v-wuzhai going forward, we will need to make a similar change in the VMR's build table: https://github.com/dotnet/dotnet/blob/main/docs/builds-table.md P4 is the first MSFT release that ships from the VMR. My assumption is that we will eventually delete the 10.0 entries from sdk's build table - maybe starting with P5. |
@ViktorHofer Does anything change about the table or is it just a duplicate of the existing table? Any concerns including 9.0.300 (at least briefly)? @v-wuzhai can you creating a PR to update the table in the dotnet/dotnet repo? Can you update the script to remove the windows arm and RHEL 6 rows as those are empty now. |
The VMR is mainly a .NET 10 and onwards thing. It's also the home for SB for 8.0.1xx and 9.0.1xx but those releases never had a build table. I wouldn't add entries pre .NET 10 to the VMR table.
It's not a 100% duplicate but it's mostly the same, yes. I.e. currently the links in it go to "10.0.1xx-ub" instead of "10.0.1xx". That will change eventually, maybe with P5. |
Thanks. I didn't notice the -ub in the aka.ms link. v-wuzhai will make sure to handle that right for the dotnet/dotnet table update. We'll be removing 9.0.300 in a few weeks anyway and then once -ub goes away, they should be identical at that point it sounds like sometime during the summer. |
@ViktorHofer I have already checked the build table. In the md file in the dotnet/dotnet repository, I found that the table in the main branch reflects the changes for P5. I tried to add the P4 column and use the links Additionally, we can remove the P3 entries in this PR and also remove the Windows arm and RHEL 6 rows. |
It's possible that we don't have a P4 build produced by the VMR yet. |
@v-wuzhai I got clarification on this. There is no -ub channel for preview 4 like there is for main. Right now both dotnet/dotnet and dotnet/sdk are publishing to the same aka.ms link for p4. For p5, it'll only be dotnet/dotnet and no dotnet/sdk. For now, we're just relying on the fact that the dotnet/dotnet build comes out later. So plan for now Plan for preview5 After prevew5, if you could update the dotnet/dotnet repo as you did before for the sdk repo and we'll just link to them from the sdk repo main page. Make sense? |
Thanks for the clarification! I've submitted three PRs based on the plan: |
No description provided.