8000 [ApiDiff] Update symbol filtering code to be able to load a list of strings or a list of files by carlossanlop · Pull Request #46255 · dotnet/sdk · GitHub
[go: up one dir, main page]
Skip to content

[ApiDiff] Update symbol filtering code to be able to load a list of strings or a list of files #46255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 29, 2025
Merged

[ApiDiff] Update symbol filtering code to be able to load a list of strings or a list of files #46255

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
22800b0
Allow creating symbol filters from files or from lists more clearly, …
carlossanlop Jan 24, 2025
e9c29aa
Update src places where symbol filtering is currently used.
carlossanlop Jan 24, 2025
4fcb4a7
Update test places where symbol filtering is used.
carlossanlop Jan 24, 2025
c9190fc
Remove unnecesary ProjectReference
carlossanlop Jan 24, 2025
493beff
Inline private method in DocIdSymbolFilter and document public APIs.
carlossanlop Jan 24, 2025
ce6e15b
Triple slash for SymbolFilterFactory.
carlossanlop Jan 24, 2025
76e959b
nit
carlossanlop Jan 24, 2025
9198d3d
Add symbol filter factory tests
carlossanlop Jan 27, 2025
6bb3f1a
count() -> length
carlossanlop Jan 27, 2025
bd8079a
Named parameters for readability
carlossanlop Jan 28, 2025
731117d
Add an optional accessibility symbol filter argument to symbol filter…
carlossanlop Jan 28, 2025
648df8a
Fix build failure in GenAPI test using SymbolFilterFactory
carlossanlop Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Named parameters for readability
  • Loading branch information
@carlossanlop
carlossanlop committed Jan 28, 2025
commit bd8079a500f5da265953b1f78ddb28231fa331bc
14 changes: 8 additions & 6 deletions src/Compatibility/ApiCompat/Microsoft.DotNet.ApiCompat.Shared/ApiCompatServiceProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,15 @@ public ApiCompatServiceProvider(Func<ISuppressionEngine, ISuppressibleLog> logFa
{
SymbolEqualityComparer symbolEqualityComparer = new();

ISymbolFilter attributeDataSymbolFilter = SymbolFilterFactory.GetFilterFromFiles(excludeAttributesFiles, respectInternals);
AttributeDataEqualityComparer attributeDataEqualityComparer = new(symbolEqualityComparer,
new TypedConstantEqualityComparer(symbolEqualityComparer));

ApiComparerSettings apiComparerSettings = new(
symbolFilter: null, // Gets a default value inside the constructor
symbolEqualityComparer,
SymbolFilterFactory.GetFilterFromFiles(excludeAttributesFiles, respectInternals),
new AttributeDataEqualityComparer(symbolEqualityComparer,
new TypedConstantEqualityComparer(symbolEqualityComparer)),
respectInternals);
symbolEqualityComparer: symbolEqualityComparer,
attributeDataSymbolFilter: attributeDataSymbolFilter,
attributeDataEqualityComparer: attributeDataEqualityComparer,
includeInternalSymbols: respectInternals);

return new ApiCompatRunner(SuppressibleLog,
SuppressionEngine,
Expand Down
Loading
0