8000 Prepare GenAPI so it can be used for a new assembly diff generator by carlossanlop · Pull Request #45389 · dotnet/sdk · GitHub
[go: up one dir, main page]
Skip to content

Prepare GenAPI so it can be used for a new assembly diff generator #45389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Prepare GenAPI so it can be used for a new assembly diff generator #45389

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8f1432e
Prepare GenAPI so it can be used for a new assembly diff generator.
carlossanlop Dec 10, 2024
bc754a6
Pass to CSharpFileBuilder constructor only the necessary arguments in…
carlossanlop Dec 10, 2024
9c60ce5
Rename DocIdSymbolFilter.GetFilterForDocIds to DocIdSymbolFilter.Create.
carlossanlop Dec 10, 2024
d8190fa
Load assemblies as dictionary instead of list, where the key is the a…
carlossanlop Dec 11, 2024
1286471
Simplify GenAPIConfiguration
carlossanlop Dec 17, 2024
3666a3a
Use factory methods instead of fluent. Get rid of GenAPIConfiguration…
carlossanlop Dec 18, 2024
a3a2c70
Address feedback and make some other improvements.
carlossanlop Jan 6, 2025
2006571
Remove unnecessary factory class and pass logger where it was missing.
carlossanlop Jan 7, 2025
a42e093
Merge CompositeSymbolFilter changes with main
carlossanlop Jan 7, 2025
b385c9c
Do not set addPartialModifier to true by default in TypeDeclarationCS…
carlossanlop Jan 7, 2025
a7358fc
Address latest batch of feedback: Rename the wrongly named CSharpAsse…
carlossanlop Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename DocIdSymbolFilter.GetFilterForDocIds to DocIdSymbolFilter.Create.
  • Loading branch information
@carlossanlop
carlossanlop committed Jan 7, 2025
commit 9c60ce554bec00fc0fb0ad31355a77a825d32e7d
2 changes: 1 addition & 1 deletion src/Compatibility/ApiCompat/Microsoft.DotNet.ApiCompat.Shared/ApiCompatServiceProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public ApiCompatServiceProvider(Func<ISuppressionEngine, ISuppressibleLog> logFa
CompositeSymbolFilter attributeDataSymbolFilter = new(accessibilitySymbolFilter);
if (excludeAttributesFiles is not null)
{
attributeDataSymbolFilter.Add(DocIdSymbolFilter.GetFilterForDocIds(excludeAttributesFiles));
attributeDataSymbolFilter.Add(DocIdSymbolFilter.Create(excludeAttributesFiles));
}

ApiComparerSettings apiComparerSettings = new(
Expand Down
4 changes: 2 additions & 2 deletions src/Compatibility/GenAPI/Microsoft.DotNet.GenAPI/GenAPIConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ public GenAPIConfiguration Build()
CompositeSymbolFilter symbolFilter = new();
if (_apiExclusionFilePaths?.Count() > 0)
{
symbolFilter.Add(DocIdSymbolFilter.GetFilterForDocIds(_apiExclusionFilePaths));
symbolFilter.Add(DocIdSymbolFilter.Create(_apiExclusionFilePaths));
}
symbolFilter.Add(new ImplicitSymbolFilter());
symbolFilter.Add(accessibilitySymbolFilter);
Expand All @@ -265,7 +265,7 @@ public GenAPIConfiguration Build()
CompositeSymbolFilter attributeDataSymbolFilter = new();
if (_attributeExclusionFilePaths?.Count() > 0)
{
attributeDataSymbolFilter.Add(DocIdSymbolFilter.GetFilterForDocIds(_attributeExclusionFilePaths));
attributeDataSymbolFilter.Add(DocIdSymbolFilter.Create(_attributeExclusionFilePaths));
}
attributeDataSymbolFilter.Add(accessibilitySymbolFilter);

Expand Down
2 changes: 1 addition & 1 deletion src/Compatibility/Microsoft.DotNet.ApiSymbolExtensions/Filtering/DocIdSymbolFilter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public class DocIdSymbolFilter : ISymbolFilter
{
private readonly HashSet<string> _docIdsToExclude;

public static DocIdSymbolFilter GetFilterForDocIds(params string[] docIdsToExclude)
public static DocIdSymbolFilter Create(params string[] docIdsToExclude)
=> new DocIdSymbolFilter(ReadDocIdsAttributes(docIdsToExclude));

private DocIdSymbolFilter(IEnumerable<string> docIdsToExclude)
Expand Down
2 changes: 1 addition & 1 deletion test/Microsoft.DotNet.ApiCompatibility.Tests/Rules/AttributesMustMatchTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public class AttributesMustMatchTests
private static readonly TestRuleFactory s_ruleFactory = new((settings, context) => new AttributesMustMatch(settings, context));

private static ISymbolFilter GetAccessibilityAndAttributeSymbolFiltersAsComposite(params string[] excludeAttributeFiles) =>
new CompositeSymbolFilter().Add(new AccessibilitySymbolFilter(false)).Add(DocIdSymbolFilter.GetFilterForDocIds(excludeAttributeFiles));
new CompositeSymbolFilter().Add(new AccessibilitySymbolFilter(false)).Add(DocIdSymbolFilter.Create(excludeAttributeFiles));

public static TheoryData<string, string, CompatDifference[]> TypesCases => new()
{
Expand Down
0