8000 [main] Update dependencies from dotnet/msbuild by dotnet-maestro[bot] · Pull Request #44977 · dotnet/sdk · GitHub
[go: up one dir, main page]

Skip to content

[main] Update dependencies from dotnet/msbuild #44977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Dec 4, 2024
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
5b56997
Update dependencies from https://github.com/dotnet/msbuild build 2024…
dotnet-maestro[bot] Nov 20, 2024
20cdb41
Update dependencies from https://github.com/dotnet/msbuild build 2024…
dotnet-maestro[bot] Nov 21, 2024
656e3cd
Update dependencies from https://github.com/dotnet/msbuild build 2024…
dotnet-maestro[bot] Nov 22, 2024
00cdbad
Created a follow up ticket, skipping affected tests to unblock mergin…
SimaTian Nov 26, 2024
efab774
forgot to skip one test
SimaTian Nov 26, 2024
67fba37
Update dependencies from https://github.com/dotnet/msbuild build 2024…
dotnet-maestro[bot] Nov 26, 2024
6710f8d
Update dependencies from https://github.com/dotnet/msbuild build 2024…
dotnet-maestro[bot] Nov 27, 2024
5ee6c9e
Update dependencies from https://github.com/dotnet/msbuild build 2024…
dotnet-maestro[bot] Nov 28, 2024
56f235f
Merge branch 'main' into darc-main-18ac571e-b280-4bd1-b026-1167471dd6fa
surayya-MS Nov 28, 2024
9019e39
Merge branch 'main' into darc-main-18ac571e-b280-4bd1-b026-1167471dd6fa
surayya-MS Nov 29, 2024
413d3b4
Update dependencies from https://github.com/dotnet/msbuild build 2024…
dotnet-maestro[bot] Nov 29, 2024
508b28b
Revert "forgot to skip one test"
surayya-MS Nov 29, 2024
1d8f45f
Revert "Created a follow up ticket, skipping affected tests to unbloc…
surayya-MS Nov 29, 2024
aaab6c4
Merge branch 'main' into darc-main-18ac571e-b280-4bd1-b026-1167471dd6fa
surayya-MS Nov 29, 2024
6c9eaeb
Update dependencies from https://github.com/dotnet/msbuild build 2024…
dotnet-maestro[bot] Nov 30, 2024
23edf3c
Merge branch 'main' into dar 8000 c-main-18ac571e-b280-4bd1-b026-1167471dd6fa
surayya-MS Dec 2, 2024
a03549a
MSBuild supports custom cultures
JanKrivanek Dec 2, 2024
8c6c968
Separate FullFW and Core test cases
JanKrivanek Dec 3, 2024
b1d5b22
Update dependencies from https://github.com/dotnet/msbuild build 2024…
dotnet-maestro[bot] Dec 3, 2024
7dcf229
Fix multiple attributes
JanKrivanek Dec 3, 2024
da69b18
Merge branch 'darc-main-18ac571e-b280-4bd1-b026-1167471dd6fa' of http…
JanKrivanek Dec 3, 2024
08b0eec
Update dependencies from https://github.com/dotnet/msbuild build 2024…
dotnet-maestro[bot] Dec 4, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Separate FullFW and Core test cases
  • Loading branch information
JanKrivanek committed Dec 3, 2024
commit 8c6c9689d626bfef4e85c2f1514ef92b9c7734e0
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@
[Theory]
[InlineData("net7.0")]
[InlineData("net6.0")]
public void SupportRespectAlreadyAssignedItemCulture_IsNotSupported_BuildShouldFail(string targetFramework)
[CoreMSBuildOnlyTheory]
public void SupportRespectAlreadyAssignedItemCulture_IsNotSupported_BuildShouldWarn(string targetFramework)

Check failure on line 34 in test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build TestBuild: linux (x64))

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs#L34

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs(34,21): error xUnit1002: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods cannot have multiple Fact or Theory attributes. Remove all but one of the attributes. (https://xunit.net/xunit.analyzers/rules/xUnit1002)

Check failure on line 34 in test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build TemplateEngine: linux (x64))

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs#L34

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs(34,21): error xUnit1002: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods cannot have multiple Fact or Theory attributes. Remove all but one of the attributes. (https://xunit.net/xunit.analyzers/rules/xUnit1002)

Check failure on line 34 in test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build TestBuild: macOS (x64))

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs#L34

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs(34,21): error xUnit1002: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods cannot have multiple Fact or Theory attributes. Remove all but one of the attributes. (https://xunit.net/xunit.analyzers/rules/xUnit1002)

Check failure on line 34 in test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build TestBuild: linux (arm64))

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs#L34

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs(34,21): error xUnit1002: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods cannot have multiple Fact or Theory attributes. Remove all but one of the attributes. (https://xunit.net/xunit.analyzers/rules/xUnit1002)

Check failure on line 34 in test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build ContainerBased: linux (x64) [centosStream9])

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs#L34

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs(34,21): error xUnit1002: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods cannot have multiple Fact or Theory attributes. Remove all but one of the attributes. (https://xunit.net/xunit.analyzers/rules/xUnit1002)

Check failure on line 34 in test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build ContainerBased: linux (x64) [ubuntu2204DebPkg])

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs#L34

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs(34,21): error xUnit1002: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods cannot have multiple Fact or Theory attributes. Remove all but one of the attributes. (https://xunit.net/xunit.analyzers/rules/xUnit1002)

Check failure on line 34 in test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build ContainerBased: linux (x64) [fedora39])

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs#L34

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs(34,21): error xUnit1002: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods cannot have multiple Fact or Theory attributes. Remove all but one of the attributes. (https://xunit.net/xunit.analyzers/rules/xUnit1002)

Check failure on line 34 in test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build AoT: macOS (x64))

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs#L34

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs(34,21): error xUnit1002: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods cannot have multiple Fact or Theory attributes. Remove all but one of the attributes. (https://xunit.net/xunit.analyzers/rules/xUnit1002)

Check failure on line 34 in test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build ContainerBased: linux (x64) [alpine319WithNode])

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs#L34

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs(34,21): error xUnit1002: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods cannot have multiple Fact or Theory attributes. Remove all but one of the attributes. (https://xunit.net/xunit.analyzers/rules/xUnit1002)

Check failure on line 34 in test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build ContainerBased: linux (x64) [debian12Amd64])

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs#L34

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs(34,21): error xUnit1002: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods cannot have multiple Fact or Theory attributes. Remove all but one of the attributes. (https://xunit.net/xunit.analyzers/rules/xUnit1002)

Check failure on line 34 in test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build TemplateEngine: macOS (x64))

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs#L34

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs(34,21): error xUnit1002: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods cannot have multiple Fact or Theory attributes. Remove all but one of the attributes. (https://xunit.net/xunit.analyzers/rules/xUnit1002)

Check failure on line 34 in test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs#L34

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs(34,21): error xUnit1002: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods cannot have multiple Fact or Theory attributes. Remove all but one of the attributes. (https://xunit.net/xunit.analyzers/rules/xUnit1002)

Check failure on line 34 in test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs#L34

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs(34,21): error xUnit1002: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods cannot have multiple Fact or Theory attributes. Remove all but one of the attributes. (https://xunit.net/xunit.analyzers/rules/xUnit1002)
{
var testAsset = _testAssetsManager
.CopyTestAsset("MSBuildCultureResourceGeneration", identifier: targetFramework)
Expand All @@ -43,5 +44,26 @@
// warning MSB3002: Explicitly set culture "test-1" for item "Resources.test-1.resx" was overwritten with inferred culture "", because 'RespectAlreadyAssignedItemCulture' property was not set.
.HaveStdOutContaining("warning MSB3002:");
}

[Theory]
[InlineData("net7.0")]
[InlineData("net6.0")]
[FullMSBuildOnlyTheory]
// Is this Failing? Is full FW MSBuild already on 17.13? Then remove this test and remove `[CoreMSBuildOnlyTheory]` attribute on the test above
//
// Until MSBuild 17.13 is merged into FullFW MSBuild in sdk tests - the test will fail, as
// proper recognition of custom cultures in RAR is not supported and hence the build will fail during copy:
//
// Microsoft.Common.CurrentVersion.targets(4959,5): error MSB3030: Could not copy the file "obj\Debug\net7.0\test-1\MSBuildCultureResourceGeneration.resources.dll" because it was not found.
public void SupportRespectAlreadyAssignedItemCulture_IsNotSupported_BuildShouldFail(string targetFramework)

Check failure on line 58 in test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build TestBuild: linux (x64))

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs#L58

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs(58,21): error xUnit1002: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods cannot have multiple Fact or Theory attributes. Remove all but one of the attributes. (https://xunit.net/xunit.analyzers/rules/xUnit1002)

Check failure on line 58 in test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build TemplateEngine: linux (x64))

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs#L58

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs(58,21): error xUnit1002: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods cannot have multiple Fact or Theory attributes. Remove all but one of the attributes. (https://xunit.net/xunit.analyzers/rules/xUnit1002)

Check failure on line 58 in test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build TestBuild: macOS (x64))

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs#L58

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs(58,21): error xUnit1002: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods cannot have multiple Fact or Theory attributes. Remove all but one of the attributes. (https://xunit.net/xunit.analyzers/rules/xUnit1002)

Check failure on line 58 in test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build TestBuild: linux (arm64))

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs#L58

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs(58,21): error xUnit1002: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods cannot have multiple Fact or Theory attributes. Remove all but one of the attributes. (https://xunit.net/xunit.analyzers/rules/xUnit1002)

Check failure on line 58 in test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build ContainerBased: linux (x64) [centosStream9])

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs#L58

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs(58,21): error xUnit1002: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods cannot have multiple Fact or Theory attributes. Remove all but one of the attributes. (https://xunit.net/xunit.analyzers/rules/xUnit1002)

Check failure on line 58 in test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build ContainerBased: linux (x64) [ubuntu2204DebPkg])

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs#L58

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs(58,21): error xUnit1002: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods cannot have multiple Fact or Theory attributes. Remove all but one of the attributes. (https://xunit.net/xunit.analyzers/rules/xUnit1002)

Check failure on line 58 in test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build ContainerBased: linux (x64) [fedora39])

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs#L58

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs(58,21): error xUnit1002: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods cannot have multiple Fact or Theory attributes. Remove all but one of the attributes. (https://xunit.net/xunit.analyzers/rules/xUnit1002)

Check failure on line 58 in test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build AoT: macOS (x64))

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs#L58

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs(58,21): error xUnit1002: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods cannot have multiple Fact or Theory attributes. Remove all but one of the attributes. (https://xunit.net/xunit.analyzers/rules/xUnit1002)

Check failure on line 58 in test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build ContainerBased: linux (x64) [alpine319WithNode])

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs#L58

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs(58,21): error xUnit1002: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods cannot have multiple Fact or Theory attributes. Remove all but one of the attributes. (https://xunit.net/xunit.analyzers/rules/xUnit1002)

Check failure on line 58 in test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build ContainerBased: linux (x64) [debian12Amd64])

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs#L58

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs(58,21): error xUnit1002: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods cannot have multiple Fact or Theory attributes. Remove all but one of the attributes. (https://xunit.net/xunit.analyzers/rules/xUnit1002)

Check failure on line 58 in test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build TemplateEngine: macOS (x64))

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs#L58

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs(58,21): error xUnit1002: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods cannot have multiple Fact or Theory attributes. Remove all but one of the attributes. (https://xunit.net/xunit.analyzers/rules/xUnit1002)

Check failure on line 58 in test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs#L58

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs(58,21): error xUnit1002: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods cannot have multiple Fact or Theory attributes. Remove all but one of the attributes. (https://xunit.net/xunit.analyzers/rules/xUnit1002)

Check failure on line 58 in test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs#L58

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs(58,21): error xUnit1002: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods cannot have multiple Fact or Theory attributes. Remove all but one of the attributes. (https://xunit.net/xunit.analyzers/rules/xUnit1002)
{
var testAsset = _testAssetsManager
.CopyTestAsset("MSBuildCultureResourceGeneration", identifier: targetFramework)
.WithSource()
.WithTargetFramework(targetFramework);

var buildCommand = new BuildCommand(testAsset);
buildCommand.Execute().Should().Fail();
}
}
}
Loading
0