8000 OutputPath (`-o`) option should ensure trialing slash · Issue #45682 · dotnet/sdk · GitHub
[go: up one dir, main page]
Skip to content

OutputPath (-o) option should ensure trialing slash #45682 8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JanKrivanek opened this issue Jan 2, 2025 · 1 comment · May be fixed by #48640
Open

OutputPath (-o) option should ensure trialing slash #45682

JanKrivanek opened this issue Jan 2, 2025 · 1 comment · May be fixed by #48640
Assignees
@dsplaisted
Labels
Area-CLI good first issue Issues that would be a good fit for someone new to the repository. Narrow in scope, well-defined.
Milestone
10.0.1xx

Comments

@JanKrivanek
Copy link
Member

Context

This was discovered here dotnet/msbuild#11057 (comment) by @KalleOlaviNiemitalo

Implicitly defined OutputPath ensures trialing slash, while explicitly passed option doesn't hold the guarantee - this can lead to inconsistent behavior of downstream commands
@ghost ghost added Area-CLI untriaged Request triage from a team member labels Jan 2, 2025
@JanKrivanek JanKrivanek mentioned this issue Jan 2, 2025
Open
@dsplaisted dsplaisted added needs team triage Requires a full team discussion and removed untriaged Request triage from a team member labels Apr 22, 2025
@marcpopMSFT marcpopMSFT added good first issue Issues that would be a good fit for someone new to the repository. Narrow in scope, well-defined. and removed needs team triage Requires a full team discussion labels Apr 22, 2025
@marcpopMSFT marcpopMSFT added this to the 10.0.1xx milestone Apr 22, 2025
@marcpopMSFT
Copy link
Member

@dotnet/kitten dsplaisted points out that this could be fixed centrally in msbuild. baronfel doesn't want us to wait for that but it might be worth exploring on the msbuild side.

@Forgind Forgind linked a pull request Apr 22, 2025 that will close this issue
Open
Forgind added a commit to Forgind/sdk that referenced this issue Apr 23, 2025
@Forgind
Add directory separator char for -o
412e287 
Fixes dotnet#45682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsplaisted dsplaisted

Labels
Area-CLI good first issue Issues that would be a good fit for someone new to the repository. Narrow in scope, well-defined.
Projects
None yet
Milestone
10.0.1xx
Development

Successfully merging a pull request may close this issue.

Add trailing slash for -o Fixes #45682 Forgind/sdk
3 participants
@dsplaisted @JanKrivanek @marcpopMSFT
0