[RISC-V] Avoid using native layout info to calculate register flags for small structs where possible by tomeksowi · Pull Request #97877 · dotnet/runtime

tomeksowi · 2024-02-02T14:30:21Z

jkotas · 2024-02-06T01:09:19Z

tomeksowi · 2024-02-06T12:22:11Z

jkotas · 2024-02-07T04:14:56Z

tomeksowi · 2024-02-07T14:50:23Z

jkotas · 2024-02-10T07:00:38Z

tomeksowi · 2024-02-12T14:51:32Z

jkotas · 2024-02-12T16:49:57Z

src/coreclr/vm/class.cpp

    pMT->SetHasExactParent();

+#ifdef TARGET_RISCV64
+    if (pMT->HasLayout() &&


It would be better to do this before SetHasExactParent call.

This is lock-free algorithm and SetHasExactParent acts as a barrier. If you do this after SetHasExactParent, it is possible for the other threads to run a lot further and hit the problem in theory.

It would be better to do this before SetHasExactParent call.

I thought about initializing native layout info earlier but that failed on "Recursion in CLRException::GetThrowable" so I committed after SetHasExactParent.

But if you say it's worth it, it's caused by a infinite loop in EnsureNativeLayoutInfoInitialized() loading System.ReadOnlySpan`1[__Canon] and CoreLibBinder::GetClass(CLASS__INT128) alternately. Not sure why after INT128 it comes back to load ReadOnlySpan, I'll try to find a circuit breaker.

brucehoult · 2024-02-29T03:54:00Z

src/coreclr/vm/class.cpp

+    {
+        // To calculate how a small struct is enregistered RISC-V needs native layout info.
+        // Initialize now so ArgIterator doesn't trigger undue class loads during GC stack walks.
+        pMT->EnsureNativeLayoutInfoInitialized();


What is it that makes this necessary on RISC-V but not on anything else?

RISC-V has more complicated calling convention than anything else. More information needs to be computed for RISC-V to interpret the calling convention. This information needs to be computed upfront - we are not able to compute it at the point where the calling convention is interpreted.

Hmm ... I thought I was reasonably familiar with the ABI, and that it is pretty similar to A64. The only thing I'd regard as a little funky is structs with one int and one fp value being passed in the next int and the next fp register, if available. Otherwise ... big things are passed by reference, return values are passed the same as the first argument, big return values pass a pointer to a buf as the first int argument, bumping the rest along. All pretty standard stuff.

Is there some particular corner case that makes it more complex?

These 500 lines compute the registers to use for a struct on RISC-V:

runtime/src/coreclr/vm/methodtable.cpp

Lines 3525 to 4027 in 0a5418d

int MethodTable::GetRiscV64PassStructInRegisterFlags(CORINFO_CLASS_HANDLE cls)

{

TypeHandle th(cls);

bool useNativeLayout = false;

int size = STRUCT_NO_FLOAT_FIELD;

MethodTable* pMethodTable = nullptr;

if (!th.IsTypeDesc())

{

pMethodTable = th.AsMethodTable();

if (pMethodTable->HasLayout())

{

useNativeLayout = true;

}

else if (th.GetSize() <= 16 /*MAX_PASS_MULTIREG_BYTES*/)

{

DWORD numIntroducedFields = pMethodTable->GetNumIntroducedInstanceFields();

if (numIntroducedFields == 1)

{

FieldDesc *pFieldStart = pMethodTable->GetApproxFieldDescListRaw();

CorElementType fieldType = pFieldStart[0].GetFieldType();

if (CorTypeInfo::IsPrimitiveType_NoThrow(fieldType))

{

if (fieldType == ELEMENT_TYPE_R4)

{

size = STRUCT_FLOAT_FIELD_ONLY_ONE;

}

else if (fieldType == ELEMENT_TYPE_R8)

{

size = STRUCT_FLOAT_FIELD_ONLY_ONE | STRUCT_FIRST_FIELD_SIZE_IS8;

}

}

else if (fieldType == ELEMENT_TYPE_VALUETYPE)

{

pMethodTable = pFieldStart->GetApproxFieldTypeHandleThrowing().GetMethodTable();

size = GetRiscV64PassStructInRegisterFlags((CORINFO_CLASS_HANDLE)pMethodTable);

}

}

else if (numIntroducedFields == 2)

{

FieldDesc *pFieldSecond;

FieldDesc *pFieldFirst = pMethodTable->GetApproxFieldDescListRaw();

if (pFieldFirst->GetOffset() == 0)

{

pFieldSecond = pFieldFirst + 1;

}

else

{

pFieldSecond = pFieldFirst;

pFieldFirst = pFieldFirst + 1;

}

assert(pFieldFirst->GetOffset() == 0);

if (pFieldFirst->GetSize() > 8)

{

goto _End_arg;

}

CorElementType fieldType = pFieldFirst[0].GetFieldType();

if (CorTypeInfo::IsPrimitiveType_NoThrow(fieldType))

{

if (fieldType == ELEMENT_TYPE_R4)

{

size = STRUCT_FLOAT_FIELD_FIRST;

}

else if (fieldType == ELEMENT_TYPE_R8)

{

size = STRUCT_FIRST_FIELD_DOUBLE;

}

else if (pFieldFirst[0].GetSize() == 8)

{

size = STRUCT_FIRST_FIELD_SIZE_IS8;

}

}

else if (fieldType == ELEMENT_TYPE_VALUETYPE)

{

pMethodTable = pFieldFirst->GetApproxFieldTypeHandleThrowing().GetMethodTable();

if (IsRiscV64OnlyOneField(pMethodTable))

{

size = GetRiscV64PassStructInRegisterFlags((CORINFO_CLASS_HANDLE)pMethodTable);

if ((size & STRUCT_FLOAT_FIELD_ONLY_ONE) != 0)

{

size = pFieldFirst[0].GetSize() == 8 ? STRUCT_FIRST_FIELD_DOUBLE : STRUCT_FLOAT_FIELD_FIRST;

}

else if (size == STRUCT_NO_FLOAT_FIELD)

{

size = pFieldFirst[0].GetSize() == 8 ? STRUCT_FIRST_FIELD_SIZE_IS8: 0;

}

else

{

size = STRUCT_NO_FLOAT_FIELD;

goto _End_arg;

}

}

else

{

size = STRUCT_NO_FLOAT_FIELD;

goto _End_arg;

}

}

else if (pFieldFirst[0].GetSize() == 8)

{

size = STRUCT_FIRST_FIELD_SIZE_IS8;

}

fieldType = pFieldSecond[0].GetFieldType();

if (pFieldSecond[0].GetSize() > 8)

{

size = STRUCT_NO_FLOAT_FIELD;

goto _End_arg;

}

else if (CorTypeInfo::IsPrimitiveType_NoThrow(fieldType))

{

if (fieldType == ELEMENT_TYPE_R4)

{

size = size & STRUCT_FLOAT_FIELD_FIRST ? (size ^ STRUCT_MERGE_FIRST_SECOND) : (size | STRUCT_FLOAT_FIELD_SECOND);

}

else if (fieldType == ELEMENT_TYPE_R8)

{

size = size & STRUCT_FLOAT_FIELD_FIRST ? (size ^ STRUCT_MERGE_FIRST_SECOND_8) : (size | STRUCT_SECOND_FIELD_DOUBLE);

}

else if ((size & STRUCT_FLOAT_FIELD_FIRST) == 0)

{

size = STRUCT_NO_FLOAT_FIELD;

}

else if (pFieldSecond[0].GetSize() == 8)

{

size |= STRUCT_SECOND_FIELD_SIZE_IS8;

}

}

else if (fieldType == ELEMENT_TYPE_VALUETYPE)

{

pMethodTable = pFieldSecond[0].GetApproxFieldTypeHandleThrowing().GetMethodTable();

if (IsRiscV64OnlyOneField(pMethodTable))

{

int size2 = GetRiscV64PassStructInRegisterFlags((CORINFO_CLASS_HANDLE)pMethodTable);

if ((size2 & STRUCT_FLOAT_FIELD_ONLY_ONE) != 0)

{

if (pFieldSecond[0].GetSize() == 8)

{

size = size & STRUCT_FLOAT_FIELD_FIRST ? (size ^ STRUCT_MERGE_FIRST_SECOND_8) : (size | STRUCT_SECOND_FIELD_DOUBLE);

}

else

{

size = size & STRUCT_FLOAT_FIELD_FIRST ? (size ^ STRUCT_MERGE_FIRST_SECOND) : (size | STRUCT_FLOAT_FIELD_SECOND);

}

}

else if ((size & STRUCT_FLOAT_FIELD_FIRST) == 0)

{

size = STRUCT_NO_FLOAT_FIELD;

}

else if (size2 == STRUCT_NO_FLOAT_FIELD)

{

size |= pFieldSecond[0].GetSize() == 8 ? STRUCT_SECOND_FIELD_SIZE_IS8 : 0;

}

else

{

size = STRUCT_NO_FLOAT_FIELD;

}

}

else

{

size = STRUCT_NO_FLOAT_FIELD;

}

}

else if ((size & STRUCT_FLOAT_FIELD_FIRST) == 0)

{

size = STRUCT_NO_FLOAT_FIELD;

}

else if (pFieldSecond[0].GetSize() == 8)

{

size |= STRUCT_SECOND_FIELD_SIZE_IS8;

}

}

goto _End_arg;

}

}

else

{

_ASSERTE(th.IsNativeValueType());

useNativeLayout = true;

pMethodTable = th.AsNativeValueType();

}

_ASSERTE(pMethodTable != nullptr);

if (useNativeLayout)

{

if (th.GetSize() <= 16 /*MAX_PASS_MULTIREG_BYTES*/)

{

DWORD numIntroducedFields = pMethodTable->GetNativeLayoutInfo()->GetNumFields();

FieldDesc *pFieldStart = nullptr;

if (numIntroducedFields == 1)

{

pFieldStart = pMethodTable->GetApproxFieldDescListRaw();

CorElementType fieldType = pFieldStart->GetFieldType();

// InlineArray types and fixed buffer types have implied repeated fields.

// Checking if a type is an InlineArray type is cheap, so we'll do that first.

bool hasImpliedRepeatedFields = HasImpliedRepeatedFields(pMethodTable);

if (hasImpliedRepeatedFields)

{

numIntroducedFields = pMethodTable->GetNumInstanceFieldBytes() / pFieldStart->GetSize();

if (numIntroducedFields > 2)

{

goto _End_arg;

}

if (fieldType == ELEMENT_TYPE_R4)

{

if (numIntroducedFields == 1)

{

size = STRUCT_FLOAT_FIELD_ONLY_ONE;

}

else if (numIntroducedFields == 2)

{

size = STRUCT_FLOAT_FIELD_ONLY_TWO;

}

goto _End_arg;

}

else if (fieldType == ELEMENT_TYPE_R8)

{

if (numIntroducedFields == 1)

{

size = STRUCT_FLOAT_FIELD_ONLY_ONE | STRUCT_FIRST_FIELD_SIZE_IS8;

}

else if (numIntroducedFields == 2)

{

size = STRUCT_FIELD_TWO_DOUBLES;

}

goto _End_arg;

}

}

if (CorTypeInfo::IsPrimitiveType_NoThrow(fieldType))

{

if (fieldType == ELEMENT_TYPE_R4)

{

size = STRUCT_FLOAT_FIELD_ONLY_ONE;

}

else if (fieldType == ELEMENT_TYPE_R8)

{

size = STRUCT_FLOAT_FIELD_ONLY_ONE | STRUCT_FIRST_FIELD_SIZE_IS8;

}

}

else if (fieldType == ELEMENT_TYPE_VALUETYPE)

{

const NativeFieldDescriptor *pNativeFieldDescs = pMethodTable->GetNativeLayoutInfo()->GetNativeFieldDescriptors();

NativeFieldCategory nfc = pNativeFieldDescs->GetCategory();

if (nfc == NativeFieldCategory::NESTED)

{

pMethodTable = pNativeFieldDescs->GetNestedNativeMethodTable();

size = GetRiscV64PassStructInRegisterFlags((CORINFO_CLASS_HANDLE)pMethodTable);

return size;

}

else if (nfc == NativeFieldCategory::FLOAT)

{

if (pFieldStart->GetSize() == 4)

{

size = STRUCT_FLOAT_FIELD_ONLY_ONE;

}

else if (pFieldStart->GetSize() == 8)

{

size = STRUCT_FLOAT_FIELD_ONLY_ONE | STRUCT_FIRST_FIELD_SIZE_IS8;

}

}

}

}

else if (numIntroducedFields == 2)

{

pFieldStart = pMethodTable->GetApproxFieldDescListRaw();

if (pFieldStart->GetSize() > 8)

{

goto _End_arg;

}

if (pFieldStart->GetOffset() || !pFieldStart[1].GetOffset() || (pFieldStart[0].GetSize() > pFieldStart[1].GetOffset()))

{

goto _End_arg;

}

CorElementType fieldType = pFieldStart[0].GetFieldType();

if (CorTypeInfo::IsPrimitiveType_NoThrow(fieldType))

{

if (fieldType == ELEMENT_TYPE_R4)

{

size = STRUCT_FLOAT_FIELD_FIRST;

}

else if (fieldType == ELEMENT_TYPE_R8)

{

size = STRUCT_FIRST_FIELD_DOUBLE;

}

else if (pFieldStart[0].GetSize() == 8)

{

size = STRUCT_FIRST_FIELD_SIZE_IS8;

}

fieldType = pFieldStart[1].GetFieldType();

if (CorTypeInfo::IsPrimitiveType_NoThrow(fieldType))

{

if (fieldType == ELEMENT_TYPE_R4)

{

size = size & STRUCT_FLOAT_FIELD_FIRST ? (size ^ STRUCT_MERGE_FIRST_SECOND) : (size | STRUCT_FLOAT_FIELD_SECOND);

}

else if (fieldType == ELEMENT_TYPE_R8)

{

size = size & STRUCT_FLOAT_FIELD_FIRST ? (size ^ STRUCT_MERGE_FIRST_SECOND_8) : (size | STRUCT_SECOND_FIELD_DOUBLE);

}

else if ((size & STRUCT_FLOAT_FIELD_FIRST) == 0)

{

size = STRUCT_NO_FLOAT_FIELD;

}

else if (pFieldStart[1].GetSize() == 8)

{

size |= STRUCT_SECOND_FIELD_SIZE_IS8;

}

goto _End_arg;

}

}

else if (fieldType == ELEMENT_TYPE_VALUETYPE)

{

const NativeFieldDescriptor *pNativeFieldDescs = pMethodTable->GetNativeLayoutInfo()->GetNativeFieldDescriptors();

NativeFieldCategory nfc = pNativeFieldDescs->GetCategory();

if (nfc == NativeFieldCategory::NESTED)

{

if (pNativeFieldDescs->GetNumElements() != 1)

{

size = STRUCT_NO_FLOAT_FIELD;

goto _End_arg;

}

MethodTable* pMethodTable2 = pNativeFieldDescs->GetNestedNativeMethodTable();

if (!IsRiscV64OnlyOneField(pMethodTable2))

{

size = STRUCT_NO_FLOAT_FIELD;

goto _End_arg;

}

size = GetRiscV64PassStructInRegisterFlags((CORINFO_CLASS_HANDLE)pMethodTable2);

if ((size & STRUCT_FLOAT_FIELD_ONLY_ONE) != 0)

{

if (pFieldStart->GetSize() == 8)

{

size = STRUCT_FIRST_FIELD_DOUBLE;

}

else

{

size = STRUCT_FLOAT_FIELD_FIRST;

}

}

else if (pFieldStart->GetSize() == 8)

{

size = STRUCT_FIRST_FIELD_SIZE_IS8;

}

else

{

size = STRUCT_NO_FLOAT_FIELD;

goto _End_arg;

}

}

else if (nfc == NativeFieldCategory::FLOAT)

{

if (pFieldStart[0].GetSize() == 4)

{

size = STRUCT_FLOAT_FIELD_FIRST;

}

else if (pFieldStart[0].GetSize() == 8)

{

_ASSERTE((pMethodTable->GetNativeSize() == 8) || (pMethodTable->GetNativeSize() == 16));

size = STRUCT_FIRST_FIELD_DOUBLE;

}

}

else if (pFieldStart[0].GetSize() == 8)

{

size = STRUCT_FIRST_FIELD_SIZE_IS8;

}

}

else if (pFieldStart[0].GetSize() == 8)

{

size = STRUCT_FIRST_FIELD_SIZE_IS8;

}

fieldType = pFieldStart[1].GetFieldType();

if (pFieldStart[1].GetSize() > 8)

{

size = STRUCT_NO_FLOAT_FIELD;

goto _End_arg;

}

else if (CorTypeInfo::IsPrimitiveType_NoThrow(fieldType))

{

if (fieldType == ELEMENT_TYPE_R4)

{

size = size & STRUCT_FLOAT_FIELD_FIRST ? (size ^ STRUCT_MERGE_FIRST_SECOND) : (size | STRUCT_FLOAT_FIELD_SECOND);

}

else if (fieldType == ELEMENT_TYPE_R8)

{

size = size & STRUCT_FLOAT_FIELD_FIRST ? (size ^ STRUCT_MERGE_FIRST_SECOND_8) : (size | STRUCT_SECOND_FIELD_DOUBLE);

}

else if ((size & STRUCT_FLOAT_FIELD_FIRST) == 0)

{

size = STRUCT_NO_FLOAT_FIELD;

}

else if (pFieldStart[1].GetSize() == 8)

{

size |= STRUCT_SECOND_FIELD_SIZE_IS8;

}

// Pass with two integer registers in `struct {int a, int b, float/double c}` cases

if ((size | STRUCT_FIRST_FIELD_SIZE_IS8 | STRUCT_FLOAT_FIELD_SECOND) == size)

{

size = STRUCT_NO_FLOAT_FIELD;

}

}

else if (fieldType == ELEMENT_TYPE_VALUETYPE)

{

const NativeFieldDescriptor *pNativeFieldDescs = pMethodTable->GetNativeLayoutInfo()->GetNativeFieldDescriptors();

NativeFieldCategory nfc = pNativeFieldDescs[1].GetCategory();

if (nfc == NativeFieldCategory::NESTED)

{

if (pNativeFieldDescs[1].GetNumElements() != 1)

{

size = STRUCT_NO_FLOAT_FIELD;

goto _End_arg;

}

MethodTable* pMethodTable2 = pNativeFieldDescs[1].GetNestedNativeMethodTable();

if (!IsRiscV64OnlyOneField(pMethodTable2))

{

size = STRUCT_NO_FLOAT_FIELD;

goto _End_arg;

}

if ((GetRiscV64PassStructInRegisterFlags((CORINFO_CLASS_HANDLE)pMethodTable2) & STRUCT_FLOAT_FIELD_ONLY_ONE) != 0)

{

if (pFieldStart[1].GetSize() == 4)

{

size = size & STRUCT_FLOAT_FIELD_FIRST ? (size ^ STRUCT_MERGE_FIRST_SECOND) : (size | STRUCT_FLOAT_FIELD_SECOND);

}

else if (pFieldStart[1].GetSize() == 8)

{

size = size & STRUCT_FLOAT_FIELD_FIRST ? (size ^ STRUCT_MERGE_FIRST_SECOND_8) : (size | STRUCT_SECOND_FIELD_DOUBLE);

}

}

else if ((size & STRUCT_FLOAT_FIELD_FIRST) == 0)

{

size = STRUCT_NO_FLOAT_FIELD;

}

else if (pFieldStart[1].GetSize() == 8)

{

size |= STRUCT_SECOND_FIELD_SIZE_IS8;

}

}

else if (nfc == NativeFieldCategory::FLOAT)

{

if (pFieldStart[1].GetSize() == 4)

{

size = size & STRUCT_FLOAT_FIELD_FIRST ? (size ^ STRUCT_MERGE_FIRST_SECOND) : (size | STRUCT_FLOAT_FIELD_SECOND);

}

else if (pFieldStart[1].GetSize() == 8)

{

size = size & STRUCT_FLOAT_FIELD_FIRST ? (size ^ STRUCT_MERGE_FIRST_SECOND_8) : (size | STRUCT_SECOND_FIELD_DOUBLE);

}

}

else if ((size & STRUCT_FLOAT_FIELD_FIRST) == 0)

{

size = STRUCT_NO_FLOAT_FIELD;

}

else if (pFieldStart[1].GetSize() == 8)

{

size |= STRUCT_SECOND_FIELD_SIZE_IS8;

}

}

else if ((size & STRUCT_FLOAT_FIELD_FIRST) == 0)

{

size = STRUCT_NO_FLOAT_FIELD;

}

else if (pFieldStart[1].GetSize() == 8)

{

size |= STRUCT_SECOND_FIELD_SIZE_IS8;

}

}

}

}

_End_arg:

return size;

}

#endif

.

Yes, GetNativeLayoutInfo() in particular is causing problems as it can trigger a full class load (in CoreLibBinder::GetClass) here:

runtime/src/coreclr/vm/classlayoutinfo.cpp

Lines 1027 to 1041 in 0a5418d

if (pMT->HasSameTypeDefAs(CoreLibBinder::GetClass(CLASS__VECTORT)))

{

pNativeLayoutInfo->m_size = pEEClassLayoutInfo->GetManagedSize();

pNativeLayoutInfo->m_alignmentRequirement = pEEClassLayoutInfo->m_ManagedLargestAlignmentRequirementOfAllMembers;

}

else

if (pMT->HasSameTypeDefAs(CoreLibBinder::GetClass(CLASS__INT128)) ||

pMT->HasSameTypeDefAs(CoreLibBinder::GetClass(CLASS__UINT128)) ||

pMT->HasSameTypeDefAs(CoreLibBinder::GetClass(CLASS__VECTOR64T)) ||

pMT->HasSameTypeDefAs(CoreLibBinder::GetClass(CLASS__VECTOR128T)) ||

pMT->HasSameTypeDefAs(CoreLibBinder::GetClass(CLASS__VECTOR256T)) ||

pMT->HasSameTypeDefAs(CoreLibBinder::GetClass(CLASS__VECTOR512T)))

{

pNativeLayoutInfo->m_alignmentRequirement = pEEClassLayoutInfo->m_ManagedLargestAlignmentRequirementOfAllMembers;

}

I've been looking at calling EnsureEnsureNativeLayoutInfoInitialized() before SetHasExactParent() as suggested but then CoreLibBinder::GetClass(CLASS__INT128) triggers EnsureEnsureNativeLayoutInfoInitialized() for it which then tries to load Int128 (at this point not fully loaded yet), which fails on a deadlock check:

runtime/src/coreclr/vm/clsload.cpp

Lines 3181 to 3185 in 0a5418d

7082

if (PendingTypeLoadHolder::CheckForDeadLockOnCurrentThread(pLoadingEntry))

{

// Attempting recursive load

ClassLoader::ThrowTypeLoadException(pTypeKey, IDS_CLASSLOAD_GENERAL);

}

I'll come back to it to figure out how to side-step this issue. It's a bit unfortunate EEClassNativeLayoutInfo::CollectNativeLayoutFieldMetadataThrowing() is doing a full class load, MethodTable::HasSameTypeDefAs() needs just the RID which I believe we get much earlier in the load sequence and the module which is a known global in CoreLibBinder.

BTW is the formula for RID fixed, i.e. given the namespace and the name for the few types enumerated, could it be calculated at compile time?

The RID formula is not fixed. The RID changes from build to build.

If all you need is the RID, you can load the Vector type explicitly upfront here:

runtime/src/coreclr/vm/appdomain.cpp

Line 1380 in 18b0816

g_pCastHelpers = CoreLibBinder::GetClass(CLASS__CASTHELPERS);

If all you need is the RID, you can load the Vector type explicitly upfront

Preloading classes for comparison gets rid of the direct problem in EEClassNativeLayoutInfo::CollectNativeLayoutFieldMetadataThrowing, thank you. I pushed WiP so far, however, I'm still hitting recursive class loads while constructing MarshalInfo here, which does a full load:

runtime/src/core 5EBE clr/vm/mlinfo.cpp

Lines 1735 to 1740 in db8f9eb

case ELEMENT_TYPE_OBJECT:

case ELEMENT_TYPE_STRING:

case ELEMENT_TYPE_CLASS:

case ELEMENT_TYPE_VAR:

{

TypeHandle sigTH = sig.GetTypeHandleThrowing(pModule, pTypeContext);

Not sure if lowering the class load level to CLASS_LOAD_APPROXPARENTS is acceptable here. The test passes but I fear the marshal info may be incorrect for generics as a result, need to confirm with CLR tests on marshalling. And there are other places in which MarshalInfo::MarshalInfo does a full class load.

What is the stack trace and the type that you are hitting this for?

What is the stack trace and the type that you are hitting this for?

Stack trace for type ImportThunkKey, some line numbers are slightly off because I inserted deoptimizing attributes

#0 ClassLoader::ThrowTypeLoadException (pKey=0x400180af28, resIDWhy=2148734242) at /runtime/src/coreclr/vm/clsload.cpp:737 #1 0x0000004001ed92aa in ClassLoader::LoadTypeHandleForTypeKey_Body (this=0x40001a97a0, pTypeKey=0x400180af28, typeHnd=..., targetLevel=CLASS_LOAD_EXACTPARENTS) at /runtime/src/coreclr/vm/clsload.cpp:3190 #2 0x0000004001ed4994 in ClassLoader::LoadTypeHandleForTypeKey (this=0x40001a97a0, pTypeKey=0x400180af28, typeHnd=..., targetLevel=CLASS_LOAD_EXACTPARENTS, pInstContext=0x0) at /runtime/src/coreclr/vm/clsload.cpp:3011 #3 0x0000004001ed60d0 in ClassLoader::LoadTypeDefThrowing (pModule=0x3f833bf130, typeDef=33555137, fNotFoundAction=ClassLoader::ThrowIfNotFound, fUninstantiated=ClassLoader::FailIfUninstDefOrRef, tokenNotToLoad=0, level=CLASS_LOAD_EXACTPARENTS, pTargetInstantiation=0x0) at /runtime/src/coreclr/vm/clsload.cpp:1998 #4 0x0000004001ed6e1e in ClassLoader::LoadTypeDefOrRefThrowing (pModule=0x3f833bf130, typeDefOrRef=33555137, fNotFoundAction=ClassLoader::ThrowIfNotFound, fUninstantiated=ClassLoader::FailIfUninstDefOrRef, tokenNotToLoad=0, level=CLASS_LOAD_EXACTPARENTS) at /runtime/src/coreclr/vm/clsload.cpp:2167 #5 0x0000004001fa8dda in SigPointer::GetTypeHandleThrowing (this=0x400180c500, pModule=0x3f833bf130, pTypeContext=0x400180c980, fLoadTypes=ClassLoader::LoadTypes, level=CLASS_LOAD_EXACTPARENTS, dropGenericArgumentLevel=0, pSubst=0x0, pZapSigContext=0x0, pMTInterfaceMapOwner=0x0, pRecursiveFieldGenericHandling=0x0) at /runtime/src/coreclr/vm/siginfo.cpp:1641 #6 0x0000004001fa88b2 in SigPointer::GetTypeHandleThrowing (this=0x400180c9c0, pModule=0x3f833bf130, pTypeContext=0x400180c980, fLoadTypes=ClassLoader::LoadTypes, level=CLASS_LOAD_EXACTPARENTS, dropGenericArgumentLevel=0, pSubst=0x0, pZapSigContext=0x0, pMTInterfaceMapOwner=0x0, pRecursiveFieldGenericHandling=0x0) at /runtime/src/coreclr/vm/siginfo.cpp:1505 #7 0x0000004001f0ea02 in MetaSig::GetLastTypeHandleThrowing (this=0x400180c978, fLoadTypes=ClassLoader::LoadTypes, level=<optimized out>, dropGenericArgumentLevel=<optimized out>) at /runtime/src/coreclr/vm/siginfo.hpp:917 #8 FieldDesc::GetFieldTypeHandleThrowing (this=<optimized out>, level=29345424, dropGenericArgumentLevel=2048) at /runtime/src/coreclr/vm/field.cpp:166 #9 0x0000004001f763e8 in MethodTable::DoFullyLoad (this=0x3f8432e568, pVisited=0x400180ceb8, level=CLASS_DEPENDENCIES_LOADED, pPending=0x0, pfBailed=0x400180cedc, pInstContext=0x0) at /runtime/src/coreclr/vm/methodtable.cpp:5197 #10 0x0000004001f7631e in MethodTable::DoFullyLoad (this=0x3f8432edb0, pVisited=0x400180d188, level=CLASS_DEPENDENCIES_LOADED, pPending=0x0, pfBailed=0x400180d1ac, pInstContext=0x0) at /runtime/src/coreclr/vm/methodtable.cpp:5176 #11 0x0000004001f7625a in MethodTable::DoFullyLoad (this=0x3f843b9e90, pVisited=0x0, level=CLASS_DEPENDENCIES_LOADED, pPending=0x0, pfBailed=0x400180d2dc, pInstContext=0x0) at /runtime/src/coreclr/vm/methodtable.cpp:5157 #12 0x0000004001ed9cce in PushFinalLevels (typeHnd=..., targetLevel=CLASS_LOADED, pInstContext=0x0) at /runtime/src/coreclr/vm/clsload.cpp:2941 #13 0x0000004001ed49f2 in ClassLoader::LoadTypeHandleForTypeKey (this=0x40001a97a0, pTypeKey=0x400180d3b8, typeHnd=..., targetLevel=CLASS_LOADED, pInstContext=0x0) at /runtime/src/coreclr/vm/clsload.cpp:3018 #14 0x0000004001ed60d0 in ClassLoader::LoadTypeDefThrowing (pModule=0x3f833bf130, typeDef=33554907, fNotFoundAction=ClassLoader::ThrowIfNotFound, fUninstantiated=ClassLoader::FailIfUninstDefOrRef, tokenNotToLoad=0, level=CLASS_LOADED, pTargetInstantiation=0x0) at /runtime/src/coreclr/vm/clsload.cpp:1998 #15 0x0000004001ed6e1e in ClassLoader::LoadTypeDefOrRefThrowing (pModule=0x3f833bf130, typeDefOrRef=33554907, fNotFoundAction=ClassLoader::ThrowIfNotFound, fUninstantiated=ClassLoader::FailIfUninstDefOrRef, tokenNotToLoad=0, level=CLASS_LOADED) at /runtime/src/coreclr/vm/clsload.cpp:2167 #16 0x0000004001fa8dda in SigPointer::GetTypeHandleThrowing (this=0x400180ef50, pModule=0x3f833bf130, pTypeContext=0x400180f2e8, fLoadTypes=ClassLoader::LoadTypes, level=CLASS_LOADED, dropGenericArgumentLevel=0, pSubst=0x0, pZapSigContext=0x0, pMTInterfaceMapOwner=0x0, pRecursiveFieldGenericHandling=0x0) at /runtime/src/coreclr/vm/siginfo.cpp:1641 #17 0x00000040020c34c2 in MarshalInfo::MarshalInfo (this=0x400180ef60, pModule=0x3f833bf130, sig=..., pTypeContext=0x400180f2e8, token=67112859, ms=MarshalInfo::MARSHAL_SCENARIO_FIELD, nlType=nltAnsi, nlFlags=nlfNone, isParam=0, paramidx=0, numArgs=0, BestFit=0, ThrowOnUnmappableChar=0, fEmitsIL=0, pMD=0x0, fLoadCustomMarshal=0, pDebugName=0x6091d48ff9 "ContainingImportSection", pDebugClassName=0x6091d552be "ImportThunkKey", argidx=4294967295) at /runtime/src/coreclr/vm/mlinfo.cpp:1742 #18 0x0000004002061abe in ParseNativeType (pModule=0x3f833bf130, sig=..., pFD=0x3f8432d1c8, flags=ParseNativeTypeFlags::IsAnsi, pNFD=0x608c029d40, pTypeContext=0x400180f2e8, szNamespace=0x6091d32afc "", szClassName=0x6091d552be "ImportThunkKey", szFieldName=0x6091d48ff9 "ContainingImportSection") at /runtime/src/coreclr/vm/fieldmarshaler.cpp:56 #19 0x0000004001ed1bae in (anonymous namespace)::ParseFieldNativeTypes (pInternalImport=0x40001b1e70, cl=33555137, fieldDescs=..., pModule=0x3f833bf130, nativeTypeFlags=ParseNativeTypeFlags::IsAnsi, pTypeContext=0x400180f2e8, pFieldInfoArrayOut=0x608c029d28, szNamespace=0x6091d32afc "", szName=0x6091d552be "ImportThunkKey") at /runtime/src/coreclr/vm/classlayoutinfo.cpp:442 #20 0x0000004001ed0d88 in EEClassNativeLayoutInfo::CollectNativeLayoutFieldMetadataThrowing (pMT=0x3f8432d430) at /runtime/src/coreclr/vm/classlayoutinfo.cpp:923 #21 0x0000004001ed05bc in EEClassNativeLayoutInfo::InitializeNativeLayoutFieldMetadataThrowing (pMT=0x3f8432d430) at /runtime/src/coreclr/vm/classlayoutinfo.cpp:844 #22 0x0000004001f7f4b0 in MethodTable::EnsureNativeLayoutInfoInitialized (this=0x3f8432d430) at /runtime/src/coreclr/vm/methodtable.cpp:9280 #23 0x0000004001ec7986 in ClassLoader::LoadExactParents (pMT=0x3f8432d430) at /runtime/src/coreclr/vm/class.cpp:1231 #24 0x0000004001ed7ec0 in ClassLoader::DoIncrementalLoad (pTypeKey=0x400180fc58, typeHnd=..., currentLevel=CLASS_LOAD_APPROXPARENTS) at /runtime/src/coreclr/vm/clsload.cpp:2634 #25 0x0000004001ed96a6 in ClassLoader::LoadTypeHandleForTypeKey_Body (this=0x40001a97a0, pTypeKey=0x400180fc58, typeHnd=..., targetLevel=CLASS_LOAD_EXACTPARENTS) at /runtime/src/coreclr/vm/clsload.cpp:3283 #26 0x0000004001ed4994 in ClassLoader::LoadTypeHandleForTypeKey (this=0x40001a97a0, pTypeKey=0x400180fc58, typeHnd=..., targetLevel=CLASS_LOAD_EXACTPARENTS, pInstContext=0x0) at /runtime/src/coreclr/vm/clsload.cpp:3011 #27 0x0000004001ed60d0 in ClassLoader::LoadTypeDefThrowing (pModule=0x3f833bf130, typeDef=33555137, fNotFoundAction=ClassLoader::ThrowIfNotFound, fUninstantiated=ClassLoader::FailIfUninstDefOrRef, tokenNotToLoad=0, level=CLASS_LOAD_EXACTPARENTS, pTargetInstantiation=0x0) at /runtime/src/coreclr/vm/clsload.cpp:1998 #28 0x0000004001ed6e1e in ClassLoader::LoadTypeDefOrRefThrowing (pModule=0x3f833bf130, typeDefOrRef=33555137, fNotFoundAction=ClassLoader::ThrowIfNotFound, fUninstantiated=ClassLoader::FailIfUninstDefOrRef, tokenNotToLoad=0, level=CLASS_LOAD_EXACTPARENTS) at /runtime/src/coreclr/vm/clsload.cpp:2167 #29 0x0000004001fa8dda in SigPointer::GetTypeHandleThrowing (this=0x4001811230, pModule=0x3f833bf130, pTypeContext=0x40018116b0, fLoadTypes=ClassLoader::LoadTypes, level=CLASS_LOAD_EXACTPARENTS, dropGenericArgumentLevel=0, pSubst=0x0, pZapSigContext=0x0, pMTInterfaceMapOwner=0x0, pRecursiveFieldGenericHandling=0x0) at /runtime/src/coreclr/vm/siginfo.cpp:1641 #30 0x0000004001fa88b2 in SigPointer::GetTypeHandleThrowing (this=0x40018116f0, pModule=0x3f833bf130, pTypeContext=0x40018116b0, fLoadTypes=ClassLoader::LoadTypes, level=CLASS_LOAD_EXACTPARENTS, dropGenericArgumentLevel=0, pSubst=0x0, pZapSigContext=0x0, pMTInterfaceMapOwner=0x0, pRecursiveFieldGenericHandling=0x0) at /runtime/src/coreclr/vm/siginfo.cpp:1505 #31 0x0000004001f0ea02 in MetaSig::GetLastTypeHandleThrowing (this=0x40018116a8, fLoadTypes=ClassLoader::LoadTypes, level=<optimized out>, dropGenericArgumentLevel=<optimized out>) at /runtime/src/coreclr/vm/siginfo.hpp:917 #32 FieldDesc::GetFieldTypeHandleThrowing (this=<optimized out>, level=29345424, dropGenericArgumentLevel=2048) at /runtime/src/coreclr/vm/field.cpp:166 #33 0x0000004001f763e8 in MethodTable::DoFullyLoad (this=0x3f8432e568, pVisited=0x4001811be8, level=CLASS_DEPENDENCIES_LOADED, pPending=0x0, pfBailed=0x4001811c0c, pInstContext=0x0) at /runtime/src/coreclr/vm/methodtable.cpp:5197 #34 0x0000004001f7631e in MethodTable::DoFullyLoad (this=0x3f8432edb0, pVisited=0x4001811eb8, level=CLASS_DEPENDENCIES_LOADED, pPending=0x0, pfBailed=0x4001811edc, pInstContext=0x0) --Type <RET> for more, q to quit, c to continue without paging--c at /runtime/src/coreclr/vm/methodtable.cpp:5176 #35 0x0000004001f7625a in MethodTable::DoFullyLoad (this=0x3f8432e968, pVisited=0x4001812188, level=CLASS_DEPENDENCIES_LOADED, pPending=0x0, pfBailed=0x40018121ac, pInstContext=0x0) at /runtime/src/coreclr/vm/methodtable.cpp:5157 #36 0x0000004001f761d0 in MethodTable::DoFullyLoad (this=0x3f84327c00, pVisited=0x4001812458, level=CLASS_DEPENDENCIES_LOADED, pPending=0x0, pfBailed=0x400181247c, pInstContext=0x0) at /runtime/src/coreclr/vm/methodtable.cpp:5138 #37 0x0000004001f761d0 in MethodTable::DoFullyLoad (this=0x3f843280d0, pVisited=0x4001812728, level=CLASS_DEPENDENCIES_LOADED, pPending=0x0, pfBailed=0x400181274c, pInstContext=0x0) at /runtime/src/coreclr/vm/methodtable.cpp:5138 #38 0x0000004001f761d0 in MethodTable::DoFullyLoad (this=0x3f84328ac8, pVisited=0x0, level=CLASS_DEPENDENCIES_LOADED, pPending=0x0, pfBailed=0x400181287c, pInstContext=0x0) at /runtime/src/coreclr/vm/methodtable.cpp:5138 #39 0x0000004001ed9cce in PushFinalLevels (typeHnd=..., targetLevel=CLASS_LOADED, pInstContext=0x0) at /runtime/src/coreclr/vm/clsload.cpp:2941 #40 0x0000004001ed49f2 in ClassLoader::LoadTypeHandleForTypeKey (this=0x40001a97a0, pTypeKey=0x4001812958, typeHnd=..., targetLevel=CLASS_LOADED, pInstContext=0x0) at /runtime/src/coreclr/vm/clsload.cpp:3018 #41 0x0000004001ed60d0 in ClassLoader::LoadTypeDefThrowing (pModule=0x3f833bf130, typeDef=33554886, fNotFoundAction=ClassLoader::ThrowIfNotFound, fUninstantiated=ClassLoader::FailIfUninstDefOrRef, tokenNotToLoad=0, level=CLASS_LOADED, pTargetInstantiation=0x0) at /runtime/src/coreclr/vm/clsload.cpp:1998 #42 0x0000004001ed6e1e in ClassLoader::LoadTypeDefOrRefThrowing (pModule=0x3f833bf130, typeDefOrRef=33554886, fNotFoundAction=ClassLoader::ThrowIfNotFound, fUninstantiated=ClassLoader::FailIfUninstDefOrRef, tokenNotToLoad=0, level=CLASS_LOADED) at /runtime/src/coreclr/vm/clsload.cpp:2167 #43 0x0000004001fa8dda in SigPointer::GetTypeHandleThrowing (this=0x40018137a0, pModule=0x3f833bf130, pTypeContext=0x4001813778, fLoadTypes=ClassLoader::LoadTypes, level=CLASS_LOADED, dropGenericArgumentLevel=0, pSubst=0x0, pZapSigContext=0x0, pMTInterfaceMapOwner=0x0, pRecursiveFieldGenericHandling=0x0) at /runtime/src/coreclr/vm/siginfo.cpp:1641 #44 0x0000004001f48a52 in CEEInfo::getArgClass (this=<optimized out>, sig=0x4001814420, args=<optimized out>) at /runtime/src/coreclr/vm/jitinterface.cpp:9693 #45 0x00000060890d1354 in Compiler::lvaInitTypeRef (this=0x400044cf48) at /runtime/src/coreclr/jit/lclvars.cpp:301 #46 0x0000006088fe425a in Compiler::compCompileHelper (this=0x400044cf48, classPtr=0x3f833bf130, compHnd=0x4001814528, methodInfo=0x4001814380, methodCodePtr=0x40018141a8, methodCodeSize=0x400181435c, compileFlags=0x40018141c8) at /runtime/src/coreclr/jit/compiler.cpp:6945 #47 0x0000006088fe310a in Compiler::compCompile(CORINFO_MODULE_STRUCT_*, void**, unsigned int*, JitFlags*)::$_0::operator()(Compiler::compCompile(CORINFO_MODULE_STRUCT_*, void**, unsigned int*, JitFlags*)::__JITParam*) const (this=<optimized out>, __JITpParam=<optimized out>) at /runtime/src/coreclr/jit/compiler.cpp:6355 #48 Compiler::compCompile (this=0x400044cf48, classPtr=0x3f833bf130, methodCodePtr=0x40018141a8, methodCodeSize=0x400181435c, compileFlags=0x40018141c8) at /runtime/src/coreclr/jit/compiler.cpp:6374 #49 0x0000006088fe5954 in jitNativeCode(CORINFO_METHOD_STRUCT_*, CORINFO_MODULE_STRUCT_*, ICorJitInfo*, CORINFO_METHOD_INFO*, void**, unsigned int*, JitFlags*, void*)::$_0::operator()(jitNativeCode(CORINFO_METHOD_STRUCT_*, CORINFO_MODULE_STRUCT_*, ICorJitInfo*, CORINFO_METHOD_INFO*, void**, unsigned int*, JitFlags*, void*)::__JITParam*) const::{lambda(jitNativeCode(CORINFO_METHOD_STRUCT_*, CORINFO_MODULE_STRUCT_*, ICorJitInfo*, CORINFO_METHOD_INFO*, void**, unsigned int*, JitFlags*, void*)::$_0::operator()(jitNativeCode(CORINFO_METHOD_STRUCT_*, CORINFO_MODULE_STRUCT_*, ICorJitInfo*, CORINFO_METHOD_INFO*, void**, unsigned int*, JitFlags*, void*)::__JITParam*) const::__JITParam*)#1}::operator()(jitNativeCode(CORINFO_METHOD_STRUCT_*, CORINFO_MODULE_STRUCT_*, ICorJitInfo*, CORINFO_METHOD_INFO*, void**, unsigned int*, JitFlags*, void*)::$_0::operator()(jitNativeCode(CORINFO_METHOD_STRUCT_*, CORINFO_MODULE_STRUCT_*, ICorJitInfo*, CORINFO_METHOD_INFO*, void**, unsigned int*, JitFlags*, void*)::__JITParam*) const::__JITParam*) const (this=<optimized out>, __JITpParam=<optimized out>) at /runtime/src/coreclr/jit/compiler.cpp:7864 #50 jitNativeCode(CORINFO_METHOD_STRUCT_*, CORINFO_MODULE_STRUCT_*, ICorJitInfo*, CORINFO_METHOD_INFO*, void**, unsigned int*, JitFlags*, void*)::$_0::operator()(jitNativeCode(CORINFO_METHOD_STRUCT_*, CORINFO_MODULE_STRUCT_*, ICorJitInfo*, CORINFO_METHOD_INFO*, void**, unsigned int*, JitFlags*, void*)::__JITParam*) const (__JITpParam=<optimized out>, this=<optimized out>) at /runtime/src/coreclr/jit/compiler.cpp:7889 #51 jitNativeCode (methodHnd=0x3f840de6b8, classPtr=0x3f833bf130, compHnd=0x4001814528, methodInfo=0x4001814380, methodCodePtr=0x40018141a8, methodCodeSize=0x400181435c, compileFlags=0x40018141c8, inlineInfoPtr=0x0) at /runtime/src/coreclr/jit/compiler.cpp:7891 #52 0x0000006088fee534 in CILJit::compileMethod (this=<optimized out>, compHnd=0x4001814528, methodInfo=0x4001814380, flags=<optimized out>, entryAddress=0x4001814ed0, nativeSizeOfCode=0x400181435c) at /runtime/src/coreclr/jit/ee_il_dll.cpp:289 #53 0x0000004001f4f726 in invokeCompileMethodHelper (jitMgr=0x40000b1220, comp=0x4001814528, info=0x4001814380, jitFlags=..., nativeEntry=0x4001814ed0, nativeSizeOfCode=0x400181435c) at /runtime/src/coreclr/vm/jitinterface.cpp:12520 #54 0x0000004001f4f894 in invokeCompileMethod (jitMgr=0x400180af28, comp=0xffffffff80131522, info=0xa6af15a049a54a00, jitFlags=..., nativeEntry=0x4001bfc690, nativeSizeOfCode=0x800) at /runtime/src/coreclr/vm/jitinterface.cpp:12583 #55 0x0000004001f5070e in UnsafeJitFunction (config=<optimized out>, ILHeader=<optimized out>, pJitFlags=0x4001814fe0, pSizeOfCode=0x40018150bc) at /runtime/src/coreclr/vm/jitinterface.cpp:13028 #56 0x0000004001f97b4c in MethodDesc::JitCompileCodeLocked (this=0x3f840de6b8, pConfig=0x40018153f0, pilHeader=0x4001815080, pEntry=0x608c0260e0, pSizeOfCode=0x40018150bc) at /runtime/src/coreclr/vm/prestub.cpp:939 #57 0x0000004001f9742a in MethodDesc::JitCompileCodeLockedEventWrapper (this=0x3f840de6b8, pConfig=0x40018153f0, pEntry=0x608c0260e0) at /runtime/src/coreclr/vm/prestub.cpp:820 #58 0x0000004001f96ae4 in MethodDesc::JitCompileCode (this=0x3f840de6b8, pConfig=0x40018153f0) at /runtime/src/coreclr/vm/prestub.cpp:707 #59 0x0000004001f96226 in MethodDesc::PrepareILBasedCode (this=0x3f840de6b8, pConfig=0x40018153f0) at /runtime/src/coreclr/vm/prestub.cpp:433 #60 0x0000004001ee02c2 in CodeVersionManager::PublishVersionableCodeIfNecessary (this=0x40000ad2d0, pMethodDesc=0x3f840de6b8, callerGCMode=CallerGCMode::Coop, doBackpatchRef=0x40018154e8, doFullBackpatchRef=<optimized out>) at /runtime/src/coreclr/vm/codeversion.cpp:1734 #61 0x0000004001f9b830 in MethodDesc::DoPrestub (this=0x3f840de6b8, pDispatchingMT=0x3f840de738, callerGCMode=CallerGCMode::Coop) at /runtime/src/coreclr/vm/prestub.cpp:2595 #62 0x0000004001f9afee in PreStubWorker (pTransitionBlock=<optimized out>, pMD=0x3f840de6b8) at /runtime/src/coreclr/vm/prestub.cpp:2424 #63 0x000000400221a49a in ThePreStub () at /runtime/src/coreclr/vm/riscv64/asmhelpers.S:378 #64 0x0000003f83f08c68 in ?? ()

jkotas · 2024-03-09T05:06:19Z

tomeksowi · 2024-03-11T14:45:15Z

tomeksowi · 2024-03-13T07:58:00Z

src/coreclr/vm/methodtable.cpp

tomeksowi · 2024-03-14T15:09:36Z

jkotas · 2024-03-14T20:29:50Z

jkotas · 2024-03-14T20:34:19Z

sirntar

tomeksowi · 2024-03-15T18:00:56Z

shushanhf · 2024-03-16T01:19:05Z

ghost added area-VM-coreclr community-contribution Indicates that the PR has been added by a community member labels Feb 2, 2024

build-analysis bot mentioned this pull request Feb 2, 2024

Tests crashing in CI with no dump: exit code 137 means SIGKILL Killed #97049

Closed

clamp03 assigned tomeksowi Feb 3, 2024

clamp03 added the arch-riscv Related to the RISC-V architecture label Feb 3, 2024

tomeksowi marked this pull request as ready for review February 5, 2024 08:38

clamp03 requested a review from jkotas February 6, 2024 00:42

tomeksowi added 3 commits February 12, 2024 12:17

Revert "[RISC-V] Skip ComputeReturnFlags in ArgIteratorTemplate::HasR…

ff49a20

…etBuffArg" This reverts commit c4f7e13.

[RISC-V] Call EnsureNativeLayoutInfoInitialized() for small structs d…

c1dd658

…uring type load to avoid undue class loads from calling GetNativeLayoutInfo() in MethodTable::GetRiscV64PassStructInRegisterFlags during GC stackwalks

Remove stale comment

5e1d745

Typo in comment

1168c37

tomeksowi changed the title ~~[RISC-V] Skip ComputeReturnFlags in ArgIteratorTemplate::HasRetBuffArg~~ [RISC-V] Initialize native layout info for small structs during type load Feb 12, 2024

jkotas reviewed Feb 12, 2024

View reviewed changes

brucehoult reviewed Feb 29, 2024

View reviewed changes

Merge main branch into skip-return-flags-for-buffer-check

e2e13a4

clamp03 mentioned this pull request Mar 8, 2024

[RISC-V] Enable crossgen for corelib #99436

Merged

WiP: move EnsureNativeLayoutInfoInitialized() before SetHasExactParent()

0292f48

SetHasExactParent() is supposed to act like a barrier to ensure the native layout is loaded before other threads use it.

build-analysis bot mentioned this pull request Mar 8, 2024

"We stopped hearing from agent Azure Pipelines 32. Verify the agent machine is running and has a healthy network connection" dotnet/dnceng#1886

Open

3 tasks

tomeksowi added 2 commits March 13, 2024 08:27

Remove initializing native layout info for small structs during type …

3d730d2

…load Managed->managed calling convention should not depend on native info which is used for interop marshalling with unmanaged code which is above the type loader.

Don't use native layout in GetRiscV64PassStructInRegisterFlags unless…

d543f74

… we're calculating flags for a native value type

tomeksowi added 2 commits March 13, 2024 12:03

Merge branch 'main' into skip-return-flags-for-buffer-check

ff713f9

Remove redundant assertions, AsNativeValueType() has the same

5ec4cb7

tomeksowi changed the title ~~[RISC-V] Initialize native layout info for small structs during type load~~ [RISC-V] Avoid using native layout info to calculate register flags for small structs where possible Mar 13, 2024

tomeksowi added 2 commits March 14, 2024 09:00

Cover implied repeated fields, a.k.a fixed arrays, in when calculatin…

0f2006a

…g small struct flags from non-native layout

Cover implied repeated fields, a.k.a fixed arrays, also in non-native…

10aacbc

… branch of IsRiscV64OnlyOneField

build-analysis bot mentioned this pull request Mar 14, 2024

System.DirectoryServices.Protocols.Tests.BerConverterTests.Decode_Bytes_ReturnsExpected failing on Windows x86 #99725

Closed

yurai007 reviewed Mar 14, 2024

View reviewed changes

src/coreclr/vm/methodtable.cpp Show resolved Hide resolved

tomeksowi requested a review from jkotas March 14, 2024 15:09

jkotas approved these changes Mar 14, 2024

View reviewed changes

sirntar approved these changes Mar 15, 2024

View reviewed changes

jkotas merged commit da2cb96 into dotnet:main Mar 15, 2024

LuckyXu-HF mentioned this pull request Mar 16, 2024

[LoongArch64] Avoid using native layout info to calculate register flags for small structs where possible. #99854

Merged

github-actions bot locked and limited conversation to collaborators Apr 15, 2024

Conversation

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants