Add regression testing for the STJv8 source generator.#95352
Merged
eiriktsarpalis merged 1 commit intodotnet:mainfrom Nov 29, 2023
Merged
Add regression testing for the STJv8 source generator.#95352eiriktsarpalis merged 1 commit intodotnet:mainfrom
eiriktsarpalis merged 1 commit intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue Detailsnull
|
tarekgh
approved these changes
Nov 28, 2023
jozkee
approved these changes
Nov 29, 2023
Member
Author
Correct, this is smoke testing functionality of the source generated baselines against the current runtime bits, so what tests are being run doesn't change much.
It depends on whether a particular release makes substantial changes to how it generates code. We have been updating the SG on every release so it made sense to include new regression tests every time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds .NET 8 source generated sources to complement the existing .NET 6 and .NET 7 regression suites.