10000 Fix GetName on TypeMetadataNode by MichalStrehovsky · Pull Request #117307 · dotnet/runtime · GitHub
[go: up one dir, main page]
Skip to content

Fix GetName on TypeMetadataNode #117307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2025
Merged

Fix GetName on TypeMetadataNode #117307

merged 1 commit into from
Jul 4, 2025

Conversation

MichalStrehovsky
Copy link
Member

MethodMetadataNode says "Method metadata", FieldMetadataNode says "Field metadata". TypeMetadataNode should say "Type metadata".

"Reflectable type" is same string as the one used on ReflectedTypeNode, causing extra confusion.

Cc @dotnet/ilc-contrib

@MichalStrehovsky
Fix GetName on TypeMetadataNode
8000
351e798 
`MethodMetadataNode` says "Method metadata", `FieldMetadataNode` says "Field metadata". `TypeMetadataNode` should say "Type metadata".

"Reflectable type" is same string as the one used on `ReflectedTypeNode`, causing extra confusion.
@Copilot Copilot AI review requested due to automatic review settings July 4, 2025 06:21
Copilot
Copilot AI reviewed Jul 4, 2025
View reviewed changes
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the GetName method of TypeMetadataNode to return a clearer descriptor for type metadata, aligning it with other metadata node naming conventions.

  • Changed the prefix in GetName from "Reflectable type: " to "Type metadata: ".

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

This was referenced Jul 4, 2025
Open
Open
@MichalStrehovsky MichalStrehovsky merged commit 91d7d53 into main Jul 4, 2025
93 of 98 checks passed
@MichalStrehovsky MichalStrehovsky deleted the MichalStrehovsky-patch-1 branch July 4, 2025 11:05
@build-analysis build-analysis bot mentioned this pull request Jul 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@jkotas jkotas jkotas approved these changes

Assignees

@MichalStrehovsky MichalStrehovsky

Labels
area-NativeAOT-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichalStrehovsky @jkotas
0