Re-enable some binary specifier tests #117304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the invalid-parse test logic in several numeric test suites to remove the old AllowBinarySpecifier shortcut now that BigInteger supports binary parsing. It simplifies the skip condition to only consider parsing failure or out-of-range values.
- Removed special-case checks for
NumberStyles.AllowBinarySpecifier - Consolidated skip logic to
!BigInteger.TryParse(...) || biout of the target range
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/libraries/System.Runtime/tests/System.Runtime.Tests/System/UInt64Tests.cs | Simplified skip condition in Parse_Invalid_TestData |
| src/libraries/System.Runtime/tests/System.Runtime.Tests/System/UInt128Tests.cs | Simplified skip condition in Parse_Invalid_TestData |
| src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Int64Tests.cs | Simplified skip condition in Parse_Invalid_TestData |
| src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Int128Tests.cs | Simplified skip condition in Parse_Invalid_TestData |
MihaZupan
approved these changes
Jul 4, 2025
This was referenced Jul 4, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.