Use the NativeBinary property instead of reconstructing the path in NativeAOT target #117294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds automatic code signing for native AOT binaries on macOS by introducing an entitlements file and new MSBuild targets.
- Introduce
entitlements.xmlwithdisable-library-validationentitlement - Add
AdHocSigntarget inMicrosoft.NETCore.Native.Unix.targetsto codesign the binary after linking - Update
CopyNativeBinaryinMicrosoft.NETCore.Native.Publish.targetsto copy the signed binary
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/coreclr/nativeaot/BuildIntegration/entitlements.xml | New entitlements file enabling disable-library-validation |
| src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets | New AdHocSign MSBuild target for ad-hoc signing on Apple platforms |
| src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets | Updated CopyNativeBinary to use the signed $(NativeBinary) |
Comments suppressed due to low confidence (4)
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets:365
- [nitpick] The target name
AdHocSignis ambiguous. Consider renaming it toCodesignNativeBinaryto clearly convey its purpose and match existing naming conventions.
<Target Name="AdHocSign"
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets:365
- [nitpick] It may be helpful to introduce a user-settable property (e.g.,
SkipCodesign) so teams can opt out of this signing step in certain CI or debug scenarios. You can conditionally run this target based on that property.
<Target Name="AdHocSign"
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets:92
- [nitpick] Add a comment to explain why we’re now copying the signed
$(NativeBinary)instead of the original output path to clarify this change for future maintainers.
<Copy SourceFiles="$(NativeBinary)" DestinationFolder="$(PublishDir)" />
src/coreclr/nativeaot/BuildIntegration/entitlements.xml:1
- The entitlements.xml needs the standard plist wrapper and XML declaration to be a valid property list. Consider adding
<?xml version=\"1.0\" encoding=\"UTF-8\"?>and<plist version=\"1.0\">before<dict>, and a closing</plist>after.
<dict>
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
|
What is the scenario that this is fixing? |
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets
Outdated
Show resolved
Hide resolved
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets
Outdated
Show resolved
Hide resolved
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets
Outdated
Show resolved
Hide resolved
This was referenced Jul 4, 2025
Open
agocke
requested changes
Jul 4, 2025
|
Reverted the codesign-related changes, left in a small change to use the NativeBinary property instead of reconstructing the path. |
agocke
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a target to codesign the native AOT binary when publishing on a Mac. Assumes no cross-compilation (which we don't support IIRC).Adds entitlements.xml with thedisable-library-validationentitlement, which appears to be necessary though I haven't determined why yet.Use the NativeBinary property instead of reconstructing the path.