[clr-interp] Include clrinterpreter library in the iOS app bundle #117277
Conversation
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props
Outdated
Show resolved
Hide resolved
src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props
Outdated
Show resolved
Hide resolved
|
Currently, the iOS simulator app dynamically links both libclrjit.dylib and libclrinterpreter.dylib. We can still statically link libclrjit_static.a, but in that case, we would need to load libclrinterpreter.dylib as a dynamic library. Once the interpreter startup path is resolved and the iOS device coreclr build is ready, I suggest switching to static linking with libclrinterpreter.a and disabling JIT entirely, so only the interpreter is statically linked. |
| @@ -115,6 +115,8 @@ | |||
| <PlatformManifestFileEntry Condition="'$(PgoInstrument)' != ''" Include="clrjit.pgd" IsNative="true" /> | |||
| <PlatformManifestFileEntry Include="libclrjit.so" IsNative="true" /> | |||
| <PlatformManifestFileEntry Include="libclrjit.dylib" IsNative="true" /> | |||
| <PlatformManifestFileEntry Condition="('$(Configuration)' == 'Debug' or '$(Configuration)' == 'Checked') or ('$(TargetArchitecture)' == 'x64' or '$(TargetArchitecture)' == 'arm64')" Include="libclrinterpreter.so" IsNative="true" /> | |||
There was a problem hiding this comment.
We often mix-and-match configurations. E.g. build checked coreclr runtime and everything else as release. Does this condition work well with this mix-and-match?
There was a problem hiding this comment.
Thanks, probably doesn't work with mix-and-match. I replaced it with CoreCLRConfiguration.
Description
This PR updates the installation target for clrinterpreter to include it in the sharedFramework, ensuring it is bundled in the iOS app.