System.CommandLine update #111864
Merged
System.CommandLine update #111864
+462
−446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uild 20250122.1 Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine From Version 0.1.552801 -> To Version 0.1.607201
|
Tagging subscribers to this area: @dotnet/area-system-console |
stephentoub
reviewed
Jan 27, 2025
| if (!Version.TryParse(result.Tokens.Single().Value, out Version? parsed)) | ||
| { | ||
| result.AddError($"'{result.Tokens[0].Value}' is not a valid Version"); | ||
| return default; |
There was a problem hiding this comment.
Nit: presumably parsed here is already default / null, so this line could just be removed?
stephentoub
approved these changes
Jan 27, 2025
|
I am adding NO-MERGE to make sure it's not merged before Preview 1 snap (VMR could suffer as most of our repos have dependency to S.CL) |
|
/azp list |
|
/azp run runtime-libraries stress-ssl |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-libraries stress-http |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jan 27, 2025
Open
…cts do not import the repo infrastructure intentionally
# Conflicts: # src/coreclr/tools/InjectResource/Program.cs
|
/azp run runtime-libraries stress-ssl |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
adamsitnik
commented
Apr 11, 2025
src/libraries/System.Net.Security/tests/StressTests/SslStress/SslStress.csproj
Outdated
Show resolved
Hide resolved
# Conflicts: # src/coreclr/tools/aot/crossgen2/Crossgen2RootCommand.cs # src/coreclr/tools/cdac-build-tool/ComposeCommand.cs # src/coreclr/tools/cdac-build-tool/Program.cs # src/libraries/System.Net.Http/tests/StressTests/HttpStress/Program.cs
adamsitnik
commented
Apr 11, 2025
src/libraries/System.Net.Http/tests/StressTests/HttpStress/HttpStress.csproj
Outdated
Show resolved
Hide resolved
|
/azp run runtime-libraries stress-ssl |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-libraries stress-http |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-libraries stress-ssl |
|
/azp run runtime-libraries stress-http |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@adamsitnik is this one ready? |
|
/ba-g the failure is unrelated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: this PR is blocked until NuGet/NuGet.Client#6236 gets merged (ETA is April).
This PR consists of three changes: