Simplify our global new/delete implementations#101826
Merged
jkoritzinsky merged 9 commits intodotnet:mainfrom May 6, 2024
Merged
Simplify our global new/delete implementations#101826jkoritzinsky merged 9 commits intodotnet:mainfrom
jkoritzinsky merged 9 commits intodotnet:mainfrom
Conversation
….NET Framework component that doesn't ship.)
…le per platform (on Windows still use the process heap, when hosted notify StressLog about OOMs)
…lete/malloc/free. Use the CRT support instead of doing it manually.
…t new() in terms of new(nothrow).
Contributor
|
Tagging subscribers to this area: @mangod9 |
jkotas
reviewed
May 6, 2024
Member
There was a problem hiding this comment.
A few questions, LGTM otherwise. Thanks!
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be
2D24
applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify our global overrides of new/delete and remove quite a bit of dead code.
new(executable)variants ofneware not used anywhere in the code-base and they won't be now that we support W/X.I'm confident that this fixes #101708 completely as all of the C++ standard libraries we use call malloc/free under the hood the same way we do (and macOS's libc++ in particular does).
There are two follow-up changes we can make that will allow us to fully remove our global new/delete overrides:
set_new_handler.std::bad_allocand translate it to our pre-allocatedOutOfMemoryExceptionobject.I plan to explore these in future PRs.